-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Rollup merge of #80538 - JulianKnodt:err_usize, r=lcnr" #80798
Conversation
Hey @rylev sorry for the trouble caused by my rollup! Could you run a perf check for this? |
@bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit 9ac4831 with merge 492b373476f18fc763cfb5b95ffc8b053d50edb0... |
☀️ Try build successful - checks-actions |
Queued 492b373476f18fc763cfb5b95ffc8b053d50edb0 with parent c8915ee, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (492b373476f18fc763cfb5b95ffc8b053d50edb0): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
The performance regressions aren't serious enough to actually warrant reverting. I think they should be investigated, but I'm closing this PR so no one actually merges it. |
This reverts commit be2a3f8, reversing
changes made to 4c4e8e7.
It's second attempt to find the cause of the perf regression in rollup (#80708).
r? @ghost