Rollup of 7 pull requests #80806
Merged
Rollup of 7 pull requests #80806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't actually a bug, it can occur when rustdoc tries to resolve a crate that isn't used in the main code.
make the generic function pattern more specific
It's no longer necessary after rust-lang#79472
and use rustc_hir_pretty directly instead
Make sure rust-call errors occur correctly for traits Fixes rust-lang#79669 Adds trait method resolution to the error, and adds UI tests to ensure it doesn't happen again. Opening as draft because I'm getting weird link errors from unrelated code on my machine, and want to see what CI thinks.
Don't panic when an external crate can't be resolved This isn't actually a bug, it can occur when rustdoc tries to resolve a crate that isn't used in the main code. Fixes rust-lang#72381. r? `@kinnison` if you have time, otherwise `@Manishearth`
…rino handle generic trait methods in coverage-report tests also make the generic function pattern more specific and remove the extra $ that fails the matching. r? `@wesleywiser` as this was failing the test of rust-lang#76896
rustc_ast_pretty: Remove `PrintState::insert_extra_parens` It's no longer necessary after rust-lang#79472. r? `@Aaron1011`
Fix type name in doc example for Iter and IterMut
Use Option::map_or instead of `.map(..).unwrap_or(..)` r? `@jyn514` `@rustbot` modify labels +C-cleanup +T-rustdoc
Get rid of custom pretty-printing in rustdoc and use rustc_hir_pretty directly instead. Closes rust-lang#79497. r? `@CraftSpider`
|
@bors r+ rollup=never p=7 |
|
📌 Commit dec3dbd has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PrintState::insert_extra_parens#80785 (rustc_ast_pretty: RemovePrintState::insert_extra_parens).map(..).unwrap_or(..)#80794 (Use Option::map_or instead of.map(..).unwrap_or(..))Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup