Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #81032

Closed
wants to merge 29 commits into from
Closed

Commits on Dec 21, 2020

  1. Don't try to add nested predicate to Rustdoc auto-trait ParamEnv

    Fixes rust-lang#80233
    
    We already have logic in `evaluate_predicates` that tries to add
    unimplemented predicates to our `ParamEnv`. Trying to add a predicate
    that already holds can lead to errors later on, since projection
    will prefer trait candidates from the `ParamEnv` to predicates from an
    impl.
    Aaron1011 committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    f2d7c05 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. First version of noop-lint

    rylev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    988e2f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58e3a4a View commit details
    Browse the repository at this point in the history
  3. Fix tests

    rylev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e29cefd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9777e0c View commit details
    Browse the repository at this point in the history
  5. Fix ui-full-deps suite

    rylev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    f3bbb98 View commit details
    Browse the repository at this point in the history
  6. Fix core tests

    rylev committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ac50400 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Configuration menu
    Copy the full SHA
    8ac6481 View commit details
    Browse the repository at this point in the history
  2. Fix std tests

    rylev committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    cdcb3b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Improve warning

    rylev committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    fd81c87 View commit details
    Browse the repository at this point in the history
  2. Fix tidy errors

    rylev committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    a356556 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Update error message

    rylev committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    8ded785 View commit details
    Browse the repository at this point in the history
  2. Fix tidy error

    rylev committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    7cf66b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Improve error messages

    rylev committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    7b7708e View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Increase accuracy of lint trigger

    estebank authored and rylev committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    59577b8 View commit details
    Browse the repository at this point in the history
  2. Clean up code rightward drift

    estebank authored and rylev committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    af88b73 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ea1d0e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a56bffb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    744f885 View commit details
    Browse the repository at this point in the history
  6. Remove doctree::Import

    CraftSpider committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    7a0f0b5 View commit details
    Browse the repository at this point in the history
  7. Address nit

    CraftSpider committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    0584ddc View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Fix JSON test

    CraftSpider committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d07bb13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a70813e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#80254 - Aaron1011:rustdoc-auto-param-env, r…

    …=estebank
    
    Don't try to add nested predicate to Rustdoc auto-trait `ParamEnv`
    
    Fixes rust-lang#80233
    
    We already have logic in `evaluate_predicates` that tries to add
    unimplemented predicates to our `ParamEnv`. Trying to add a predicate
    that already holds can lead to errors later on, since projection
    will prefer trait candidates from the `ParamEnv` to predicates from an
    impl.
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e0ef0c2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#80723 - rylev:noop-lint-pass, r=estebank

    Implement NOOP_METHOD_CALL lint
    
    Implements the beginnings of rust-lang/lang-team#67 - a lint for detecting noop method calls (e.g, calling `<&T as Clone>::clone()` when `T: !Clone`).
    
    This PR does not fully realize the vision and has a few limitations that need to be addressed either before merging or in subsequent PRs:
    * [ ] No UFCS support
    * [ ] The warning message is pretty plain
    * [ ] Doesn't work for `ToOwned`
    
    The implementation uses [`Instance::resolve`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/instance/struct.Instance.html#method.resolve) which is normally later in the compiler. It seems that there are some invariants that this function relies on that we try our best to respect. For instance, it expects substitutions to have happened, which haven't yet performed, but we check first for `needs_subst` to ensure we're dealing with a monomorphic type.
    
    Thank you to `@davidtwco,` `@Aaron1011,` and `@wesleywiser` for helping me at various points through out this PR ❤️.
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fb6e491 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#80834 - bugadani:vecdeque, r=oli-obk

    Remove unreachable panics from VecDeque::{front/back}[_mut]
    
    `VecDeque`'s `front`, `front_mut`, `back` and `back_mut` methods are implemented in terms of the index operator, which causes these functions to contain [unreachable panic calls](https://rust.godbolt.org/z/MTnq1o).
    
    This PR reimplements these methods in terms of `get[_mut]` instead.
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fdeb2f2 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#80944 - LingMan:map_or, r=nagisa

    Use Option::map_or instead of `.map(..).unwrap_or(..)`
    
    `@rustbot` modify labels +C-cleanup +T-compiler
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    9053e65 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#81008 - tmiasko:generator-layout-err, r=tma…

    …ndry
    
    Don't ICE when computing a layout of a generator tainted by errors
    
    Fixes rust-lang#80998.
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    11a63fb View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#81021 - CraftSpider:rustdoc-remove-import, …

    …r=jyn514
    
    Remove doctree::Import
    
    Per the title. Part of cleaning up doctree
    JohnTitor authored Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e2e9e34 View commit details
    Browse the repository at this point in the history