Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit rustc_middle::dep_graph module documentation #81130

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Edit rustc_middle::dep_graph module documentation #81130

merged 1 commit into from
Jan 24, 2021

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Jan 17, 2021 •
edited
Loading

This is similar to work approved and then closed in #80325 due to a bad rebase.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 17, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 17, 2021

r? @cjgillot

@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Jan 17, 2021
camelid
camelid reviewed Jan 19, 2021
View reviewed changes
compiler/rustc_middle/src/dep_graph/dep_node.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/dep_graph/dep_node.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/dep_graph/dep_node.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/dep_graph/dep_node.rs Outdated Show resolved Hide resolved
jyn514
jyn514 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

compiler/rustc_middle/src/dep_graph/dep_node.rs Outdated Show resolved Hide resolved
@pierwill @camelid
Edit rustc_middle::dep_graph module documentation
b29353a 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Co-authored-by: Camelid <camelidcamel@gmail.com>
@pierwill pierwill requested a review from jyn514 January 22, 2021 23:15
@jyn514
Copy link
Member

jyn514 commented Jan 23, 2021

@bors r+ rolllup

@bors
Copy link
Contributor

bors commented Jan 23, 2021

📌 Commit b29353a has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 23, 2021

@bors rollup

@jonas-schievink jonas-schievink mentioned this pull request Jan 23, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2021
@bors
Auto merge of rust-lang#81304 - jonas-schievink:rollup-d9kuugm, r=jon…
1279b3b 
…as-schievink

Rollup of 15 pull requests

Successful merges:

 - rust-lang#79841 (More clear documentation for NonNull<T>)
 - rust-lang#81072 (PlaceRef::ty: use method call syntax)
 - rust-lang#81130 (Edit rustc_middle::dep_graph module documentation)
 - rust-lang#81170 (Avoid hash_slice in VecDeque's Hash implementation)
 - rust-lang#81243 (mir: Improve size_of handling when arg is unsized)
 - rust-lang#81245 (Update cargo)
 - rust-lang#81249 (Lower closure prototype after its body.)
 - rust-lang#81252 (Add more self-profile info to rustc_resolve)
 - rust-lang#81275 (Fix <unknown> queries and add more timing info to render_html)
 - rust-lang#81281 (Inline methods of Path and OsString)
 - rust-lang#81283 (Note library tracking issue template in tracking issue template.)
 - rust-lang#81285 (Remove special casing of rustdoc in rustc_lint)
 - rust-lang#81288 (rustdoc: Fix visibility of trait and impl items)
 - rust-lang#81298 (replace RefCell with Cell in FnCtxt)
 - rust-lang#81301 (Fix small typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 57d6553 into rust-lang:master Jan 24, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 24, 2021
@pierwill pierwill deleted the edit-depnode branch February 17, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid Awaiting requested review from camelid

@jyn514 jyn514 Awaiting requested review from jyn514

Assignees

@cjgillot cjgillot

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
8 participants
@pierwill @rust-highfive @jyn514 @bors @camelid @cjgillot @matthewjasper @rustbot