-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine: stop eagerly evaluating consts #81351
Conversation
Oh yea, this is much better than the @bors r+ |
📌 Commit 77a9e3e has been approved by |
⌛ Testing commit 77a9e3e with merge a66e013a0fccd15e427b25cc4122409e5fc1f5e9... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
not your fault, a lot of (all) PRs are failing right now |
@bors retry this should work again now |
combine: stop eagerly evaluating consts `super_relate_consts` eagerly evaluates constants which doesn't seem too great. I now also finally understand why all of the unused substs test passed. The reason being that we just evaluated the constants in `super_relate_consts` 😆 While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way r? `@oli-obk` `@nikomatsakis`
combine: stop eagerly evaluating consts `super_relate_consts` eagerly evaluates constants which doesn't seem too great. I now also finally understand why all of the unused substs test passed. The reason being that we just evaluated the constants in `super_relate_consts` 😆 While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way r? `@oli-obk` `@nikomatsakis`
This comment has been minimized.
This comment has been minimized.
⌛ Testing commit 464148861190c9ca672b791c8f844b2ae90fe039 with merge b3f2d67077ff5351688e467fe7a90a8c0e5ea72f... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
4641488
to
e461ddd
Compare
@bors r=oli-obk |
📌 Commit e461ddd has been approved by |
⌛ Testing commit e461ddd with merge ec6a92f2161b0ac80d6333dee4d29a115097a062... |
@bors retry (included in rollup) |
Rollup of 8 pull requests Successful merges: - rust-lang#81351 (combine: stop eagerly evaluating consts) - rust-lang#82525 (make unaligned_references future-incompat lint warn-by-default) - rust-lang#82626 (update array missing `IntoIterator` msg) - rust-lang#82917 (Add function core::iter::zip) - rust-lang#82993 (rustdoc: Use diagnostics for error when including sources) - rust-lang#83522 (Improve fs error open_from unix) - rust-lang#83548 (Always preserve `None`-delimited groups in a captured `TokenStream`) - rust-lang#83555 (Add #[inline] to io::Error methods) Failed merges: - rust-lang#83130 (escape_ascii take 2) r? `@ghost` `@rustbot` modify labels: rollup
super_relate_consts
eagerly evaluates constants which doesn't seem too great.I now also finally understand why all of the unused substs test passed. The reason being
that we just evaluated the constants in
super_relate_consts
😆While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way
r? @oli-obk @nikomatsakis