Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtest: Wait for test threads to exit after they report completion #81367

Merged
merged 2 commits into from
Jan 26, 2021
Merged

libtest: Wait for test threads to exit after they report completion #81367

merged 2 commits into from
Jan 26, 2021

Commits on Jan 25, 2021

  1. libtest: Wait for test threads to exit after they report completion 

    Otherwise we can miss bugs where a test reports that it succeeded but
then panics within a TLS destructor.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk
    andersk committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    57c72ab View commit details
    Browse the repository at this point in the history

  2. libtest: Store pending timeouts in a deque 

    This reduces the total complexity of checking timeouts from quadratic
to linear, and should also fix an unwrap of None on completion of an
already timed-out test.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk
    andersk committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    b05788e View commit details
    Browse the repository at this point in the history