Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustdoc text selection for page titles #81459

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fix rustdoc text selection for page titles #81459

merged 1 commit into from
Jan 29, 2021

Conversation

probablykasper
Copy link
Contributor

Fixes text selection of page titles by placing the h1.fqn span.in-band element before h1.fqn span.out-of-band.

Before vs after:
https://user-images.githubusercontent.com/11315492/105768203-55708700-5f5c-11eb-924b-4e7527ffe147.mp4

Retry of PR #81397 due to merge conflicts confusing me. Recreated the same changes as in that PR, but now when I run ./x.py doc library/std, no changes I make to src/librustdoc/html/render/mod.rs to the file are reflected in the built doc files, even if I delete the build folder. I'm guessing there's some cache I'm missing?

r? @Nemo157

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nemo157 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2021
@probablykasper probablykasper mentioned this pull request Jan 28, 2021
Closed
@camelid camelid added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 28, 2021
@Nemo157
Copy link
Member

Nemo157 commented Jan 28, 2021

Recreated the same changes as in that PR, but now when I run ./x.py doc library/std, no changes I make to src/librustdoc/html/render/mod.rs to the file are reflected in the built doc files, even if I delete the build folder. I'm guessing there's some cache I'm missing?

Default is to build docs using the stage 0 compiler (a.k.a. the beta compiler used for bootstrapping). To get the updated docs from your changed compiler you need to use ./x.py doc std --stage 1.

@Nemo157
Copy link
Member

Nemo157 commented Jan 28, 2021

Looks good to me, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2021

📌 Commit 74f26a1 has been approved by Nemo157

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2021
@probablykasper
Copy link
Contributor Author

@Nemo157 Ah I see, thanks. Confirmed the fix works as expected.

@JohnTitor JohnTitor mentioned this pull request Jan 29, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2021
@bors
Auto merge of rust-lang#81493 - JohnTitor:rollup-sa4m4zh, r=JohnTitor
74500b9 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#79570 (rustc: Stabilize `-Zrun-dsymutil` as `-Csplit-debuginfo`)
 - rust-lang#79819 (Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` lint)
 - rust-lang#79991 (rustdoc: Render HRTB correctly for bare functions)
 - rust-lang#80215 (Use -target when linking binaries for Mac Catalyst)
 - rust-lang#81158 (Point to span of upvar making closure FnMut)
 - rust-lang#81176 (Improve safety of `LateContext::qpath_res`)
 - rust-lang#81287 (Split rustdoc JSON types into separately versioned crate)
 - rust-lang#81306 (Fuse inner iterator in FlattenCompat and improve related tests)
 - rust-lang#81333 (clean up some const error reporting around promoteds)
 - rust-lang#81459 (Fix rustdoc text selection for page titles)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2b4fa3d into rust-lang:master Jan 29, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

Assignees

@Nemo157 Nemo157

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
6 participants
@probablykasper @rust-highfive @Nemo157 @bors @camelid @rustbot