name async generators something more human friendly in type error diagnostic #81496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
guswynn
force-pushed
the
expected_async_block
branch
2 times, most recently
from
e3ce9a6
to
8eb484d
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
requested changes
Jan 29, 2021
rustbot
added
S-waiting-on-author
|
Yah, I will have time for this tomorrow!
…On Sun, Feb 14, 2021, 9:07 AM John Simon ***@***.***> wrote:
Ping from triage - @guswynn <https://github.com/guswynn>
can you please resolve the build failure?
@rustbot <https://github.com/rustbot> label: -S-waiting-on-review
+S-waiting-on-author
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#81496 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJHND24ZTNHLER6RHQF65LS677MJANCNFSM4WYDKGHA>
.
|
guswynn
force-pushed
the
expected_async_block
branch
from
8eb484d
to
0019a00
Compare
|
Fixed the build issue (apparently ui/issues is too big these days?) also, @oli-obk It appears that async fn's trigger a different path with arguably better (tho somewhat confusing) wording, and async closures also have better wording I think the async fn one could be improved, but as a separate pr. I have left it in the test because we should have a test for the 3 main async generator types regardless |
guswynn
force-pushed
the
expected_async_block
branch
from
0019a00
to
e4bdeef
Compare
guswynn
force-pushed
the
expected_async_block
branch
from
e4bdeef
to
c28d86c
Compare
|
@bors r+ rollup |
|
📌 Commit c28d86c has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 18, 2021
…-obk name async generators something more human friendly in type error diagnostic fixes rust-lang#81457 Some details: 1. I opted to load the generator kind from the hir in TyCategory. I also use 1 impl in the hir for the descr 2. I named both the source of the future, in addition to the general type (`future`), not sure what is preferred 3. I am not sure what is required to make sure "generator" is not referred to anywhere. A brief `rg "\"generator\"" showed me that most diagnostics correctly distinguish from generators and async generator, but the `descr` of `DefKind` is pretty general (not sure how thats used) 4. should the descr impl of AsyncGeneratorKind use its display impl instead of copying the string?
bors
added
S-waiting-on-author
|
@Dylan-DPC looks like I got unlucky with a merge that made hir.rs larger...I added a commit with the suppression the error suggested |
|
@bors r=oli-obk rollup |
|
📌 Commit 3e7ea40 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#79747 (Add explanations and suggestions to `irrefutable_let_patterns` lint) - rust-lang#81496 (name async generators something more human friendly in type error diagnostic) - rust-lang#81873 (Add Mutex::unlock) - rust-lang#82093 (Add tests for Atomic*::fetch_{min,max}) - rust-lang#82238 (ast: Keep expansion status for out-of-line module items) - rust-lang#82245 (Do not ICE when evaluating locals' types of invalid `yield`) - rust-lang#82259 (Fix popping singleton paths in when generating E0433) - rust-lang#82261 (rustdoc: Support argument files) - rust-lang#82274 (libtest: Fix unwrap panic on duplicate TestDesc) - rust-lang#82275 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #81457
Some details:
future), not sure what is preferredrg "\"generator\"" showed me that most diagnostics correctly distinguish from generators and async generator, but thedescrofDefKind` is pretty general (not sure how thats used)