Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let a portion of DefPathHash uniquely identify the DefPath's crate. #81635

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Let a portion of DefPathHash uniquely identify the DefPath's crate. #81635

merged 5 commits into from
Mar 8, 2021

Commits on Feb 2, 2021

  1. Let a portion of DefPathHash uniquely identify the DefPath's crate. 

    This allows to directly map from a DefPathHash to the crate it
originates from, without constructing side tables to do that mapping.

It also allows to reliably and cheaply check for DefPathHash collisions.
    @michaelwoerister
    michaelwoerister committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    22d489b View commit details
    Browse the repository at this point in the history

  2. Update UI tests affected by changed DefPathHash value construction.

    @michaelwoerister
    michaelwoerister committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    6a4878f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Add documentation to Unhasher impl for Fingerprint.

    @michaelwoerister
    michaelwoerister committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    d4d8bdf View commit details
    Browse the repository at this point in the history

  2. Add more explanation to local DefPathHash collision case.

    @michaelwoerister
    michaelwoerister committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    97380e3 View commit details
    Browse the repository at this point in the history

  3. Add unit test to ensure that both parts of a DefPathHash depend on th… 

    …e defining crate's ID.
    @michaelwoerister
    michaelwoerister committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9e50544 View commit details
    Browse the repository at this point in the history