Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert allow semicolons lint #81695

Closed

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Feb 3, 2021

Reverts #81541 and #79819 to fix #81531 which is hitting many users of nightly.

cc @Aaron1011

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2021
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
Checking which error codes lack tests...
Found 435 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_lint_defs/src/builtin.rs: too many lines (3020) (add `// ignore-tidy-filelength` to the file to suppress this error)
some tidy checks failed

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build"
expected success, got: exit code: 1

@petrochenkov
Copy link
Contributor

#81541 is supposed to be the fix for #81531.
Perhaps it didn't hit nightly yet?

@petrochenkov
Copy link
Contributor

@Aaron1011
Looks like #81541 forgets to process the node id in ExprKind::Async.

@jethrogb
Copy link
Contributor Author

jethrogb commented Feb 3, 2021

#81541 is supposed to be the fix for #81531.
Perhaps it didn't hit nightly yet?

It did, but it doesn't work. See my comment there.

@petrochenkov
Copy link
Contributor

@jethrogb
Instead of reverting, could you make a PR that applies the same treatment as #81541 to the NodeId in ExprKind::Async?
(I'd do it myself, but I'm on vacation with an extra slow PC.)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2021
@petrochenkov
Copy link
Contributor

Superseded by #81699.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal compiler error: failed to process buffered lint here
4 participants