-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hack for js-sys and time-macros-impl #81863
Conversation
@bors try |
⌛ Trying commit e8bd318866167eb330ee8523d8ce58d0f7fb2a6e with merge 9c1dcf141bc0875407c4eb36972857bd3db713e2... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@craterbot check |
🚨 Error: missing start toolchain 🆘 If you have any trouble with Crater please ping |
☀️ Try build successful - checks-actions |
e8bd318
to
78588bb
Compare
@craterbot check |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
? |
First crater run: 440 regressions (https://crater-reports.s3.amazonaws.com/pr-73084-1/index.html) I think that the next step is to add a future-incompat-report lint once rust-lang/cargo#8825 is merged |
@Aaron1011 Ping from triage! Now that pr has been merged. What's next steps here? |
☔ The latest upstream changes (presumably #83149) made this pull request unmergeable. Please resolve the merge conflicts. |
We are now emitting lints for both of these cases - there's still too much breakage to remove the hack entirely. |
r? @ghost