Show macro name in 'this error originates in macro' message #82069

Aaron1011 · 2021-02-13T19:53:49Z

When there are multiple macros in use, it can be difficult to tell
which one was responsible for producing an error.

rust-highfive · 2021-02-13T19:53:52Z

(rust-highfive has picked a reviewer for you, use r? to override)

jyn514 · 2021-02-13T22:25:12Z

src/test/ui/allocator/not-an-allocator.stderr

@@ -5,7 +5,7 @@ LL | static A: usize = 0;
   | ^^^^^^^^^^^^^^^^^^^^ the trait `GlobalAlloc` is not implemented for `usize`
   |
   = note: required by `std::alloc::GlobalAlloc::alloc`
-   = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)
+   = note: this error originates in the attribute macro `global_allocator` (in Nightly builds, run with -Z macro-backtrace for more info)


Unrelated to this PR, but would it be possible to only show "run with -Z macro-backtrace" in nightly builds, the same way the compiler only suggests #![feature] on nightly?

For months I've thought of suggesting this but kept forgetting, so thanks for suggesting it!

This can be a very useful option for debugging macros, so I think it's good to make people aware of it. Unlike #![feature]s, this option is something can be enabled just for local testing, without requiring that anyone else use a nightly compiler.

@Aaron1011's observation is exactly the reason I didn't gate that suggestion on being in nightly.

bors · 2021-02-18T10:44:37Z

☔ The latest upstream changes (presumably #82249) made this pull request unmergeable. Please resolve the merge conflicts.

henryboisdequin · 2021-03-03T01:33:28Z

@rustbot label +S-waiting-on-author -S-waiting-on-review

Aaron1011 · 2021-03-04T01:04:01Z

This PR is extremely prone to bit-rotting. Once @matthewjasper or someone else is ready to r+ the general concept, I'll rebase and immediately approve it with p=1.

Dylan-DPC-zz · 2021-03-20T13:08:16Z

r? @estebank

JohnCSimon · 2021-04-04T17:49:43Z

Triage:
Assigning back to author for build failure.

@rustbot label: -S-waiting-on-review +S-waiting-on-author

Aaron1011 · 2021-04-04T18:00:17Z

@JohnCSimon: The build failure is expected - I'll rebase and bless the tests once the overall concept is approved, due to the bitrot potential.

cjgillot · 2021-04-04T18:05:18Z

src/test/ui/issues/issue-70724-add_type_neq_err_label-unwrap.stderr

@@ -33,7 +33,7 @@ LL |     assert_eq!(a, 0);
   = help: use parentheses to call the function: `a()`
   = note: required because of the requirements on the impl of `Debug` for `&fn() -> i32 {a}`
   = note: required by `std::fmt::Debug::fmt`
-   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
+   = note: this error originates in the macro `$crate::format_args` (in Nightly builds, run with -Z macro-backtrace for more info)


Is $crate meant to be exposed this way?

Probably not. I'll open an issue to track resolving this.

JohnTitor · 2021-05-12T21:31:17Z

@bors r- --^

When there are multiple macros in use, it can be difficult to tell which one was responsible for producing an error.

Aaron1011 · 2021-05-12T23:06:01Z

@bors r=estebank p=1 rollup=never

bors · 2021-05-12T23:06:02Z

📌 Commit 0dd9f11 has been approved by estebank

bors · 2021-05-13T00:31:43Z

⌛ Testing commit 0dd9f11 with merge 9daf546...

bors · 2021-05-13T02:56:47Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 9daf546 to master...

rust-lang/rust#82069 made error message that stem macro invocations more verbose. Since Rust 1.54 (currently in beta) the message includes the name of the offending macro. This PR uses version_check to select the appropriate expected error message.

rust-highfive assigned matthewjasper Feb 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2021

This comment has been minimized.

Sign in to view

Aaron1011 force-pushed the verbose-in-macro branch from 150c412 to 4aa73f6 Compare February 13, 2021 20:59

This comment has been minimized.

Sign in to view

jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2021

jyn514 approved these changes Feb 13, 2021

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021

Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2021

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2021

rust-highfive assigned estebank and unassigned matthewjasper Mar 20, 2021

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2021

Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2021

cjgillot reviewed Apr 4, 2021

View reviewed changes

crlf0710 added the I-needs-decision Issue: In need of a decision. label Apr 23, 2021

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 12, 2021

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2021

Show macro name in 'this error originates in macro' message

0dd9f11

When there are multiple macros in use, it can be difficult to tell which one was responsible for producing an error.

Aaron1011 force-pushed the verbose-in-macro branch from 01919db to 0dd9f11 Compare May 12, 2021 23:05

Aaron1011 removed the I-needs-decision Issue: In need of a decision. label May 12, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2021

bors merged commit 9daf546 into rust-lang:master May 13, 2021

rustbot added this to the 1.54.0 milestone May 13, 2021

This was referenced May 13, 2021

Remove #[cfg] attributes during cfg-expansion #84110

Closed

Introduce hir::ExprKind::Let - Take 2 #80357

Merged

Aaron1011 mentioned this pull request May 13, 2021

Error message contains $crate instead of crate name #85244

Open

This was referenced Jul 2, 2021

Replace rust_macro test to work on nightly djc/askama#511

Merged

Fix expected error message for missing file djc/askama#512

Merged

MauriceKayser added a commit to MauriceKayser/rs-bitfield that referenced this pull request Oct 17, 2021

Adjust TryBuild messages for rust-lang/rust#82069

d8acfed

MauriceKayser added a commit to MauriceKayser/rs-bitfield that referenced this pull request Oct 4, 2022

Adjust TryBuild messages for rust-lang/rust#82069

8befd41

MauriceKayser added a commit to MauriceKayser/rs-bitfield that referenced this pull request Jan 3, 2024

Adjust TryBuild messages for rust-lang/rust#82069

f838567

MauriceKayser added a commit to MauriceKayser/rs-bitfield that referenced this pull request Jan 4, 2024

Adjust TryBuild messages for rust-lang/rust#82069

3f81268

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show macro name in 'this error originates in macro' message #82069

Show macro name in 'this error originates in macro' message #82069

Aaron1011 commented Feb 13, 2021

rust-highfive commented Feb 13, 2021

This comment has been minimized.

This comment has been minimized.

jyn514 Feb 13, 2021

camelid Feb 14, 2021

Aaron1011 Mar 4, 2021

estebank May 9, 2021

bors commented Feb 18, 2021

henryboisdequin commented Mar 3, 2021

Aaron1011 commented Mar 4, 2021

Dylan-DPC-zz commented Mar 20, 2021

JohnCSimon commented Apr 4, 2021 •

edited

Loading

Aaron1011 commented Apr 4, 2021 •

edited

Loading

cjgillot Apr 4, 2021

Aaron1011 May 12, 2021

This comment has been minimized.

JohnTitor commented May 12, 2021

Aaron1011 commented May 12, 2021

bors commented May 12, 2021

bors commented May 13, 2021

bors commented May 13, 2021

Show macro name in 'this error originates in macro' message #82069

Show macro name in 'this error originates in macro' message #82069

Conversation

Aaron1011 commented Feb 13, 2021

rust-highfive commented Feb 13, 2021

This comment has been minimized.

This comment has been minimized.

jyn514 Feb 13, 2021

Choose a reason for hiding this comment

camelid Feb 14, 2021

Choose a reason for hiding this comment

Aaron1011 Mar 4, 2021

Choose a reason for hiding this comment

estebank May 9, 2021

Choose a reason for hiding this comment

bors commented Feb 18, 2021

henryboisdequin commented Mar 3, 2021

Aaron1011 commented Mar 4, 2021

Dylan-DPC-zz commented Mar 20, 2021

JohnCSimon commented Apr 4, 2021 • edited Loading

Aaron1011 commented Apr 4, 2021 • edited Loading

cjgillot Apr 4, 2021

Choose a reason for hiding this comment

Aaron1011 May 12, 2021

Choose a reason for hiding this comment

This comment has been minimized.

JohnTitor commented May 12, 2021

Aaron1011 commented May 12, 2021

bors commented May 12, 2021

bors commented May 13, 2021

bors commented May 13, 2021

JohnCSimon commented Apr 4, 2021 •

edited

Loading

Aaron1011 commented Apr 4, 2021 •

edited

Loading