Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing env!-decl variant #82118

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Add missing env!-decl variant #82118

merged 2 commits into from
Feb 16, 2021

Conversation

lukaslueg
Copy link
Contributor

Resolves #82117

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2021
@jyn514 jyn514 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 14, 2021
@lukaslueg
Update library/core/src/macros/mod.rs
3d7fcff 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@m-ou-se
Copy link
Member

m-ou-se commented Feb 14, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 14, 2021

📌 Commit 3d7fcff has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 15, 2021
@JohnTitor
Rollup merge of rust-lang#82118 - lukaslueg:env_decl, r=m-ou-se
ebaba22 
Add missing env!-decl variant

Resolves rust-lang#82117
@JohnTitor JohnTitor mentioned this pull request Feb 15, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 15, 2021
@JohnTitor
Rollup merge of rust-lang#82118 - lukaslueg:env_decl, r=m-ou-se
3d4b4a6 
Add missing env!-decl variant

Resolves rust-lang#82117
@JohnTitor JohnTitor mentioned this pull request Feb 15, 2021
Closed
This was referenced Feb 15, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2021
@bors
Auto merge of rust-lang#82153 - jonas-schievink:rollup-ls5r943, r=jon…
42a4673 
…as-schievink

Rollup of 19 pull requests

Successful merges:

 - rust-lang#81503 (Suggest to create a new `const` item if the `fn` in the array is a `const fn`)
 - rust-lang#81897 (Add match pattern diagnostics regression test)
 - rust-lang#81975 (Seal the CommandExt, OsStrExt and OsStringExt traits)
 - rust-lang#82009 (const_generics: Dont evaluate array length const when handling errors)
 - rust-lang#82060 (Fix typos in BTreeSet::{first, last} docs)
 - rust-lang#82061 (CTFE validation: catch ReadPointerAsBytes and better error)
 - rust-lang#82063 (Fixed minor typo in catch_unwind docs)
 - rust-lang#82067 (const_generics: Fix incorrect ty::ParamEnv::empty() usage)
 - rust-lang#82077 (Edit `rustc_arena::DropArena` docs)
 - rust-lang#82096 (Fix a typo)
 - rust-lang#82106 (Remove unnecessary `Option` in `default_doc`)
 - rust-lang#82107 (expand: Some cleanup)
 - rust-lang#82118 (Add missing env!-decl variant)
 - rust-lang#82119 (Fix typo in link to CreateSymbolicLinkW documentation.)
 - rust-lang#82120 (Stabilize Arguments::as_str)
 - rust-lang#82129 (Remove redundant bool_to_option feature gate)
 - rust-lang#82133 (Update link for extern prelude.)
 - rust-lang#82141 (32-bit ARM: Emit `lr` instead of `r14` when specified as an `asm!` output register.)
 - rust-lang#82147 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b0bd056 into rust-lang:master Feb 16, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 16, 2021
@lukaslueg lukaslueg deleted the env_decl branch February 16, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Documented syntax for core::env is wrong
7 participants
@lukaslueg @rust-highfive @m-ou-se @bors @jyn514 @joshtriplett @rustbot