Use !Sync std::lazy::OnceCell in usefulness checking #82155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rustc_data_structures::sync::OnceCell` is thread-safe when building a parallel compiler. This is unnecessary for the purposes of pattern usefulness checking. Use `!Sync` `std::lazy::OnceCell` instead.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
added
I-compiletime
jyn514
approved these changes
Feb 16, 2021
|
@bors r+ |
|
📌 Commit 64b5b75 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 18, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#82055 (Add diagnostics for specific cases for const/type mismatch err) - rust-lang#82155 (Use !Sync std::lazy::OnceCell in usefulness checking) - rust-lang#82202 (add specs for riscv32/riscv64 musl targets) - rust-lang#82203 (Move some tests to more reasonable directories - 4) - rust-lang#82211 (make `suggest_setup` help messages better) - rust-lang#82212 (Remove redundant rustc_data_structures path component) - rust-lang#82240 (remove useless ?s (clippy::needless_question_marks)) - rust-lang#82243 (Add more intra-doc links to std::io) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustc_data_structures::sync::OnceCellis thread-safe when buildinga parallel compiler. This is unnecessary for the purposes of pattern
usefulness checking. Use
!Syncstd::lazy::OnceCellinstead.