avoid full-slicing slices #82163
Merged
avoid full-slicing slices #82163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we already have a slice, there is no need to get another full-range slice from that, just use the original. clippy::redundant_slicing
|
r? @lcnr (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 4390a61 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
C-cleanup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2021
avoid full-slicing slices If we already have a slice, there is no need to get another full-range slice from that, just use the original. clippy::redundant_slicing
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 16, 2021
avoid full-slicing slices If we already have a slice, there is no need to get another full-range slice from that, just use the original. clippy::redundant_slicing
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#82145 (Fix ES5 errors (IE11)) - rust-lang#82160 (Fix typo in rustc_infer::infer::UndoLog) - rust-lang#82161 (Add long explanation for E0545) - rust-lang#82163 (avoid full-slicing slices) - rust-lang#82175 (validation: fix invalid-fn-ptr error message) - rust-lang#82184 ([Minor] Update discriminant_value docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we already have a slice, there is no need to get another full-range slice from that, just use the original.
clippy::redundant_slicing