Eagerly construct bodies of THIR #82495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeSeulArtichaut
added
C-cleanup
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit e18ff276230854ec1e0a8b862404fd6ddaa4dff0 with merge d296f83141af1e476f62f693effd6e2ddea1d895... |
3 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
LeSeulArtichaut
force-pushed
the
eager-thir
branch
from
e18ff27
to
abd9376
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit abd9376b42b94d6be535f32dc2479472e9965701 with merge c344bcecedd7364ad5a35c43651d91d308d606e7... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
eager-thir
branch
from
abd9376
to
ea2480d
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit ea2480d67d1a3c369d04fde50f3804a38b3e320a with merge c9341d3c23489a6e2b016c435e81944b6e559096... |
This comment has been minimized.
This comment has been minimized.
|
☀️ Try build successful - checks-actions |
|
Queued c9341d3c23489a6e2b016c435e81944b6e559096 with parent a8486b6, future comparison URL. |
|
Finished benchmarking try commit (c9341d3c23489a6e2b016c435e81944b6e559096): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
Can you see this ui test failure locally, too? I don't see how your changes could cause it, since you didn't deduplicate anything yet, but maybe the asm checking logic is hooking into THIR somewhere? |
This comment has been minimized.
This comment has been minimized.
|
I'm unable to reproduce the test failure. I also tried NLL compare mode ( |
LeSeulArtichaut
force-pushed
the
eager-thir
branch
from
0518d22
to
d6c737a
Compare
|
Then let's see if it was spurious @bors r+ |
|
📌 Commit d6c737a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d6c737a with merge 6cef6d831f2187ee66f85ebf899fd8766eac10eb... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
|
☀️ Test successful - checks-actions |
This was referenced Mar 11, 2021
Merged
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…astorino Add `-Z unpretty` flag for the THIR This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate. Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062. Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR. r? `@spastorino` cc `@estebank`
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…astorino Add `-Z unpretty` flag for the THIR This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate. Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062. Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR. r? ``@spastorino`` cc ``@estebank``
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…astorino Add `-Z unpretty` flag for the THIR This adds a new perma-unstable flag, `-Zunpretty=thir-tree`, that dumps the raw THIR tree for each body in the crate. Implements the THIR part of MCP rust-lang/compiler-team#408, helps with rust-lang/rustc-dev-guide#1062. Depends on rust-lang#82495, blocked on that. Only the two last commits are added by this PR. r? ```@spastorino``` cc ```@estebank```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR:
BoxesHowever, this PR doesn't make any changes to the way patterns are constructed: they are still boxed, and exhaustiveness checking is unchanged.
Implements MCP rust-lang/compiler-team#409.
Closes rust-lang/project-thir-unsafeck#1.
r? @ghost cc @nikomatsakis @oli-obk