Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracing to 0.1.25 #82553

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Update tracing to 0.1.25 #82553

merged 1 commit into from
Mar 3, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 26, 2021

  • Update tracing from 0.1.18 to 0.1.25
  • Update tracing-subscriber from 0.2.13 to 0.2.16
  • Update tracing-tree from 0.1.6 to 0.1.8
  • Add pin-project-lite to the list of allowed dependencies (it is now a direct dependency of tracing).

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2021
@rust-log-analyzer

This comment has been minimized.

@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 26, 2021

Added pin-project-lite, which is now a direct dependency of tracing, to the list of allowed dependencies

@bors
Copy link
Contributor

bors commented Feb 28, 2021

☔ The latest upstream changes (presumably #82611) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Could you provide a link to the changelogs and some particular rationale for this update (beyond just keeping things up to date)?

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 3, 2021

The release notes can be found at:

I was originally motivated by slight reduction in a code generated for statically disabled instrumentation, although I don't see it explicitly mentioned in release notes for that version. The rest is indeed just to keep things up-to date.

@rustbot label: +S-waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2021
@Mark-Simulacrum
Copy link
Member

I've done the digging now, but it would've been great to provide the changelog in a more directed fashion - e.g., links to each release - if the upstream crate doesn't maintain a changelog file.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2021
@bors
Copy link
Contributor

bors commented Mar 3, 2021

⌛ Trying commit 2abe7c8 with merge f2c6646afcc0b532fc328d7fa18c47749d8d9610...

@bors
Copy link
Contributor

bors commented Mar 3, 2021

☀️ Try build successful - checks-actions
Build commit: f2c6646afcc0b532fc328d7fa18c47749d8d9610 (f2c6646afcc0b532fc328d7fa18c47749d8d9610)

@rust-timer
Copy link
Collaborator

Queued f2c6646afcc0b532fc328d7fa18c47749d8d9610 with parent 939b143, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f2c6646afcc0b532fc328d7fa18c47749d8d9610): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2021
@Mark-Simulacrum
Copy link
Member

Seems to be a mild improvement overall, though potentially a regression in compile times (hard to say if noise or not). @bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2021

📌 Commit 2abe7c8 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
@bors
Copy link
Contributor

bors commented Mar 3, 2021

⌛ Testing commit 2abe7c8 with merge 476acbf...

@bors
Copy link
Contributor

bors commented Mar 3, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 476acbf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2021
@bors bors merged commit 476acbf into rust-lang:master Mar 3, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 3, 2021
@tmiasko tmiasko deleted the update-tracing branch March 3, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants