-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tracing to 0.1.25 #82553
Update tracing to 0.1.25 #82553
Conversation
tmiasko
commented
Feb 26, 2021
•
edited
Loading
edited
- Update tracing from 0.1.18 to 0.1.25
- Update tracing-subscriber from 0.2.13 to 0.2.16
- Update tracing-tree from 0.1.6 to 0.1.8
- Add pin-project-lite to the list of allowed dependencies (it is now a direct dependency of tracing).
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
3e7c6ef
to
e019db4
Compare
Added pin-project-lite, which is now a direct dependency of tracing, to the list of allowed dependencies |
☔ The latest upstream changes (presumably #82611) made this pull request unmergeable. Please resolve the merge conflicts. |
e019db4
to
2abe7c8
Compare
Could you provide a link to the changelogs and some particular rationale for this update (beyond just keeping things up to date)? |
The release notes can be found at:
I was originally motivated by slight reduction in a code generated for statically disabled instrumentation, although I don't see it explicitly mentioned in release notes for that version. The rest is indeed just to keep things up-to date. @rustbot label: +S-waiting-on-review |
I've done the digging now, but it would've been great to provide the changelog in a more directed fashion - e.g., links to each release - if the upstream crate doesn't maintain a changelog file. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2abe7c8 with merge f2c6646afcc0b532fc328d7fa18c47749d8d9610... |
☀️ Try build successful - checks-actions |
Queued f2c6646afcc0b532fc328d7fa18c47749d8d9610 with parent 939b143, future comparison URL. |
Finished benchmarking try commit (f2c6646afcc0b532fc328d7fa18c47749d8d9610): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Seems to be a mild improvement overall, though potentially a regression in compile times (hard to say if noise or not). @bors r+ |
📌 Commit 2abe7c8 has been approved by |
☀️ Test successful - checks-actions |