Rustdoc Json: Add tests for Reexports, and improve jsondocck #82571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-rustdoc-json
rust-highfive
added
the
S-waiting-on-review
CraftSpider
approved these changes
Feb 28, 2021
aDotInTheVoid
force-pushed
the
reexport-tests
branch
from
3da447b to
c3d375d
Compare
This comment has been minimized.
This comment has been minimized.
aDotInTheVoid
force-pushed
the
reexport-tests
branch
from
c3d375d to
e6dacc5
Compare
jyn514
approved these changes
Mar 10, 2021
Comment on lines
+16
to
+17
| // @has - "$.index[*][?(@.name=='glob_extern')].inner.items[*]" $public_fn_id | ||
| pub use mod1::*; |
There was a problem hiding this comment.
This re-export is inlined, so the JSON shows the items at the crate root?
There was a problem hiding this comment.
I'm not sure I understand the question, but yes, it shows up in the crate root
Output
{
"crate_version": null,
"external_crates": {},
"format_version": 4,
"includes_private": false,
"index": {
"0:0": {
"attrs": ["#![no_core]", "#![feature(no_core)]"],
"crate_id": 0,
"deprecation": null,
"docs": null,
"id": "0:0",
"inner": {"is_crate": true, "items": ["0:3"]},
"kind": "module",
"links": {},
"name": "glob_extern",
"source": {"begin": [3, 0], "end": [13, 16], "filename": "glob_extern.rs"},
"visibility": "public"
},
"0:3": {
"attrs": [],
"crate_id": 0,
"deprecation": null,
"docs": null,
"id": "0:3",
"inner": {
"abi": "\"C\"",
"decl": {"c_variadic": false, "inputs": [], "output": null},
"generics": {"params": [], "where_predicates": []},
"header": ["unsafe"]
},
"kind": "function",
"links": {},
"name": "public_fn",
"source": {"begin": [8, 8], "end": [8, 27], "filename": "glob_extern.rs"},
"visibility": "public"
}
},
"paths": {
"0:0": {"crate_id": 0, "kind": "module", "path": ["glob_extern"]},
"0:3": {"crate_id": 0, "kind": "function", "path": ["glob_extern", "public_fn"]}
},
"root": "0:0"
}
|
@bors delegate=CraftSpider |
|
✌️ @CraftSpider can now approve this pull request |
|
@rustbot modify labels: -S-waiting-on-review +S-waiting-on-author |
rustbot
added
S-waiting-on-author
aDotInTheVoid
force-pushed
the
reexport-tests
branch
from
ba3cd29 to
5f24798
Compare
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
rustbot
added
S-waiting-on-review
|
Looks nice, thanks for the improvements! |
|
📌 Commit 5f24798 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…ftSpider Rustdoc Json: Add tests for Reexports, and improve jsondocck The two changes are orthognal, so you can land just one if you want, but the improved errors realy helped write the tests. Notably does not have the case from rust-lang#80664, but I want to have all the ajacent cases tested before starting work on that to ensure I dont break anything. Improves rust-lang#81359 cc `@CraftSpider` r? `@jyn514` `@rustbot` modify labels: +A-testsuite +T-rustdoc +A-rustdoc-json
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
…ftSpider Rustdoc Json: Add tests for Reexports, and improve jsondocck The two changes are orthognal, so you can land just one if you want, but the improved errors realy helped write the tests. Notably does not have the case from rust-lang#80664, but I want to have all the ajacent cases tested before starting work on that to ensure I dont break anything. Improves rust-lang#81359 cc ``@CraftSpider`` r? ``@jyn514`` ``@rustbot`` modify labels: +A-testsuite +T-rustdoc +A-rustdoc-json
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#80385 (Clarify what `Cell::replace` returns) - rust-lang#82571 (Rustdoc Json: Add tests for Reexports, and improve jsondocck) - rust-lang#82860 (Add `-Z unpretty` flag for the THIR) - rust-lang#82950 (convert slice doc link to intra-doc links) - rust-lang#82965 (Add spirv extension handling in compiletest) - rust-lang#82966 (update MSYS2 link in README) - rust-lang#82979 (Fix "run" button position in error index) - rust-lang#83001 (Ignore Vim swap files) - rust-lang#83003 (rustdoc: tweak the search index format) - rust-lang#83013 (Adjust some `#[cfg]`s to take non-Unix non-Windows operating systems into account) - rust-lang#83018 (Reintroduce accidentally deleted assertions.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two changes are orthognal, so you can land just one if you want, but the improved errors realy helped write the tests.
Notably does not have the case from #80664, but I want to have all the ajacent cases tested before starting work on that to ensure I dont break anything.
Improves #81359
cc @CraftSpider
r? @jyn514
@rustbot modify labels: +A-testsuite +T-rustdoc +A-rustdoc-json