Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport some LLVM compile-time improvements #82783

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 4, 2021

Pick up two LLVM patches that reduce number of alias analysis queries, to see whether that gives any visible improvement.

r? @ghost

@nikic
Copy link
Contributor Author

nikic commented Mar 4, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2021
@bors
Copy link
Contributor

bors commented Mar 4, 2021

⌛ Trying commit 3081eafd4373baf97ec55b1d97174714e5cf9ba2 with merge 57645773c360978a7ca9935c2c58f8394fc97e0a...

@bors
Copy link
Contributor

bors commented Mar 5, 2021

☀️ Try build successful - checks-actions
Build commit: 57645773c360978a7ca9935c2c58f8394fc97e0a (57645773c360978a7ca9935c2c58f8394fc97e0a)

@rust-timer
Copy link
Collaborator

Queued 57645773c360978a7ca9935c2c58f8394fc97e0a with parent 45b3c28, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (57645773c360978a7ca9935c2c58f8394fc97e0a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 5, 2021
@nikic
Copy link
Contributor Author

nikic commented Mar 5, 2021

Minor improvements to opt builds and a 1.5% improvement on bootstrap.

r? @nagisa Does this seems worthwhile? If so, I'll push this to the branch and update the submodule reference.

@nagisa
Copy link
Member

nagisa commented Mar 5, 2021

This does seem quite worthwhile yes. I'm comfortable with the LICM changes, since they have been landed upstream, but I wasn't able to find the diffs or commits corresponding to the [Loads] commits upstream. If they have been submitted, can the differential be referenced in the commit messages? If not, can we quantify the impact of the LICM change alone vs the improvements gained from the Loads commits?

@nikic
Copy link
Contributor Author

nikic commented Mar 5, 2021

@nagisa The upstream commits are llvm/llvm-project@7c706aa, llvm/llvm-project@e0615bc, llvm/llvm-project@3d8f842, llvm/llvm-project@29034f3. I should get into the habit of using git cherry-pick -x...

@nagisa
Copy link
Member

nagisa commented Mar 5, 2021

Yeah LGTM then, r=me once these commits end up in a proper branch.

This backports two compile-time improvements from the LLVM 13
branch, which reduce the number of alias analysis queries.
@nikic nikic changed the title [perf] Try backporting some compile-time improvements Backporting some LLVM compile-time improvements Mar 5, 2021
@nikic nikic changed the title Backporting some LLVM compile-time improvements Backport some LLVM compile-time improvements Mar 5, 2021
@nikic
Copy link
Contributor Author

nikic commented Mar 5, 2021

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Mar 5, 2021

📌 Commit c484bfe has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2021
@bors
Copy link
Contributor

bors commented Mar 8, 2021

⌛ Testing commit c484bfe with merge 1d6b0f6...

@bors
Copy link
Contributor

bors commented Mar 8, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 1d6b0f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2021
@bors bors merged commit 1d6b0f6 into rust-lang:master Mar 8, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 8, 2021
@leonardo-m
Copy link

This seems to have fixed some performance regressions (perhaps with the help of other things in the last week) introduced by LLVM12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants