-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Add an unstable option to print all unversioned files #82803
Conversation
This allows querying it programatically.
This comment has been minimized.
This comment has been minimized.
Meta: could you add "rustdoc" to PR names so that it's clear that an option is added (or some other change is made) to rustdoc rather than to rustc. Labels like |
Sure thing, I'll do that. |
5ea970f
to
d6c9a6f
Compare
It's kinda doing the opposite of what I had in mind but the end result is the same so it's just as good. Can you add a test for it the newly added option please? |
d6c9a6f
to
11d50c0
Compare
Oops, I forgot to commit it to git. Should be up now. |
11d50c0
to
5411db4
Compare
for file in crate::html::render::FILES_UNVERSIONED.keys() { | ||
println!("{}", file); | ||
} | ||
return Err(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really bad API usage we have here... We should clean that up later on.
Thanks! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
This allows sharing those files between different doc invocations without having to know their names ahead of time.
5411db4
to
173d2aa
Compare
@bors r=GuillaumeGomez |
📌 Commit 173d2aa has been approved by |
…meGomez rustdoc: Add an unstable option to print all unversioned files This allows sharing those files between different doc invocations without having to know their names ahead of time. Helps with rust-lang/docs.rs#1302. r? `@GuillaumeGomez` cc `@pietroalbini` `@Nemo157`
…meGomez rustdoc: Add an unstable option to print all unversioned files This allows sharing those files between different doc invocations without having to know their names ahead of time. Helps with rust-lang/docs.rs#1302. r? ``@GuillaumeGomez`` cc ``@pietroalbini`` ``@Nemo157``
…meGomez rustdoc: Add an unstable option to print all unversioned files This allows sharing those files between different doc invocations without having to know their names ahead of time. Helps with rust-lang/docs.rs#1302. r? ```@GuillaumeGomez``` cc ```@pietroalbini``` ```@Nemo157```
Rollup of 13 pull requests Successful merges: - rust-lang#77916 (Change built-in kernel targets to be os = none throughout) - rust-lang#82130 (Make some Option, Result methods unstably const) - rust-lang#82292 (Prevent specialized ZipImpl from calling `__iterator_get_unchecked` twice with the same index) - rust-lang#82402 (Remove RefCell around `module_trait_cache`) - rust-lang#82592 (Improve transmute docs with further clarifications) - rust-lang#82651 (Cleanup rustdoc warnings) - rust-lang#82720 (Fix diagnostic suggests adding type `[type error]`) - rust-lang#82751 (improve offset_from docs) - rust-lang#82793 (Move some tests to more suitable subdirs) - rust-lang#82803 (rustdoc: Add an unstable option to print all unversioned files) - rust-lang#82808 (Sync rustc_codegen_cranelift) - rust-lang#82822 (Fix typo) - rust-lang#82837 (tweak MaybeUninit docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This allows sharing those files between different doc invocations
without having to know their names ahead of time.
Helps with rust-lang/docs.rs#1302.
r? @GuillaumeGomez cc @pietroalbini @Nemo157