Add support for storing code model to LLVM module IR #83044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch avoids undefined behavior by linking different object files. Also this would it could be propagated properly to LTO. See https://reviews.llvm.org/D52322 and https://reviews.llvm.org/D52323. This patch is based on rust-lang#74002
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikic
reviewed
Mar 12, 2021
src/test/codegen/codemodels.rs
Outdated
| // revisions: NOMODEL MODEL-SMALL MODEL-KERNEL MODEL-MEDIUM MODEL-LARGE | ||
| //[NOMODEL] compile-flags: | ||
| //[MODEL-SMALL] compile-flags: -C code-model=small | ||
| //[MODEL-KERNEL] compile-flags: --target x86_64-unknown-linux-gnu -C code-model=kernel |
There was a problem hiding this comment.
Pretty sure this is going to fail because not all builder have an x86_64-unknown-linux-gnu target (in particular, those where this is not the host target).
You need to either make this test only-x86_64, or drop the kernel code model part of the test, if that's not portable to other targets.
There was a problem hiding this comment.
There's an alternative option of using:
// needs-llvm-components:
together with a #[no_core] example.
|
@bors r+ rollup |
|
📌 Commit 2feccf0 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 12, 2021
Add support for storing code model to LLVM module IR This patch avoids undefined behavior by linking different object files. Also this would it could be propagated properly to LTO. See https://reviews.llvm.org/D52322 and https://reviews.llvm.org/D52323. This patch is based on rust-lang#74002
|
Failed in rollup: #83063 (comment) |
bors
added
S-waiting-on-author
kubo39
force-pushed
the
set-llvm-code-model
branch
from
2feccf0 to
7141838
Compare
|
@bors r+ |
|
📌 Commit 7141838 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch avoids undefined behavior by linking different object files.
Also this would it could be propagated properly to LTO.
See https://reviews.llvm.org/D52322 and https://reviews.llvm.org/D52323.
This patch is based on #74002