Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Command::spawn (no semantic change) #83170

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Simplify Command::spawn (no semantic change) #83170

merged 1 commit into from
Mar 30, 2021

Conversation

joshtriplett
Copy link
Member

This minimizes the size of an unsafe block, and allows outdenting some
complex code.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2021
@joshtriplett
Copy link
Member Author

Note that I based this PR on the branch from #83121 , to avoid a conflict.

@kennytm
Copy link
Member

kennytm commented Mar 17, 2021

CI not running? 🤔

@kennytm kennytm closed this Mar 17, 2021
@kennytm kennytm reopened this Mar 17, 2021
@joshtriplett
Copy link
Member Author

I'd like to hold off on this one until #81825 gets in, since the two will likely conflict and that one has been waiting longer. I'll rebase this after that goes in.

@kennytm kennytm added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2021
@voidc
Copy link
Contributor

voidc commented Mar 19, 2021

I also don't mind rebasing #81825 if you want to merge this first.

@joshtriplett
Copy link
Member Author

@voidc I appreciate that, but this is a minor cleanup and I'm much more interested in the pidfd work.

@joshtriplett
Simplify Command::spawn (no semantic change)
68dbdfb 
This minimizes the size of an unsafe block, and allows outdenting some
complex code.
@joshtriplett
Copy link
Member Author

Since #81825 seems to be blocked by an LLVM codegen issue, I'd like to go ahead and merge this.

@joshtriplett joshtriplett added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 29, 2021
@joshtriplett
Copy link
Member Author

@kennytm

@kennytm
Copy link
Member

kennytm commented Mar 30, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2021

📌 Commit 68dbdfb has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2021
@bors
Copy link
Contributor

bors commented Mar 30, 2021

⌛ Testing commit 68dbdfb with merge 7b6fc5a...

@bors
Copy link
Contributor

bors commented Mar 30, 2021

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing 7b6fc5a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2021
@bors bors merged commit 7b6fc5a into rust-lang:master Mar 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Mar 30, 2021
This was referenced Mar 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@joshtriplett @rust-highfive @kennytm @voidc @bors @rustbot