Fix #83045 by moving some crate loading verification code to a better place #83404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
T-compiler
eddyb
approved these changes
Mar 24, 2021
eddyb
reviewed
Mar 24, 2021
| $(BARE_RUSTC) --out-dir $(TMPDIR) --extern b=$(TMPDIR)/libb.rlib --crate-type=rlib \ | ||
| --edition=2018 c.rs &> $(TMPDIR)/output.txt || exit 0 | ||
| # Check that we get the expected error message | ||
| $(CGREP) "error[E0463]" < $(TMPDIR)/output.txt |
There was a problem hiding this comment.
You probably need backslashes for the [ and ]?
Might be easier to match on the message itself which is:
can't find crate for `a` which `b` depends on
There was a problem hiding this comment.
I'll just match on E0463. That should be sufficient.
|
r=me with CI fixed |
michaelwoerister
force-pushed
the
issue83045
branch
from
753a697
to
4ab0434
Compare
This comment has been minimized.
This comment has been minimized.
michaelwoerister
force-pushed
the
issue83045
branch
from
4ab0434
to
416c555
Compare
This comment has been minimized.
This comment has been minimized.
|
I don't understand what's going on here. The string to be matched is right there in the output and the test passes for me locally |
michaelwoerister
force-pushed
the
issue83045
branch
from
416c555
to
03f8ee6
Compare
This comment has been minimized.
This comment has been minimized.
michaelwoerister
force-pushed
the
issue83045
branch
from
03f8ee6
to
6de2a61
Compare
This comment has been minimized.
This comment has been minimized.
michaelwoerister
force-pushed
the
issue83045
branch
from
6de2a61
to
cac9eef
Compare
This comment has been minimized.
This comment has been minimized.
michaelwoerister
force-pushed
the
issue83045
branch
from
cac9eef
to
7d7c047
Compare
This comment has been minimized.
This comment has been minimized.
… a better place.
michaelwoerister
force-pushed
the
issue83045
branch
from
7d7c047
to
09bab38
Compare
|
OK, piping the compiler's output through @bors r=eddyb |
|
📌 Commit 09bab38 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb