Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Option wrapping around Crate.module #83415

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Remove unnecessary Option wrapping around Crate.module #83415

merged 4 commits into from
Mar 24, 2021

Commits on Mar 23, 2021

  1. rustdoc: Record crate name instead of using None

    @camelid
    camelid committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    72a180e View commit details
    Browse the repository at this point in the history

  2. Don't push the crate name onto the Cache.stack 

    Now that we record the crate's name in its `clean::Item`, pushing the
crate name onto the `stack` causes duplicate paths. E.g., the URL
generated for the path `::foo::bar::baz` would be something like

    ../foo/foo/bar/baz

With this commit, the URL is corrected to

    ../foo/bar/baz
    @camelid
    camelid committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    c9ae359 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary Option wrapping around Crate.module 

    I'm wondering if it was originally there so that we could `take` the
module which enables `after_krate` to take an `&Crate`. However, the two
impls of `after_krate` only use `Crate.name`, so we can pass just the
name instead.
    @camelid
    camelid committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    68244fc View commit details
    Browse the repository at this point in the history

  4. Remove another unnecessary Option 

    The previous changes mean that we can now remove this `Option`.
    @camelid
    camelid committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    a7f902b View commit details
    Browse the repository at this point in the history