-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_apfloat: fix typo in is_denormal #83725
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
Looks like this was a porting mistake of mine. But also, we don't even use the PPC code. I'll go poke the people dealing with the licensing limbo just to make sure approving this tiny PR won't make anything slightly worse. |
@eddyb Per the file that @klensy linked, they derived this change from a file that is licensed under The University of Illinois Open Source License, which means that we should assume this change must be licensed as the same. Since you originally ported rustc-apfloat from a codebase under the same license, this doesn't change anything about the licensing of rustc-apfloat. |
closing this as there's no much interest in this atm, we can revisit it some other time. Thanks |
Sources:
https://github.com/llvm-mirror/llvm/blob/23efab2bbd424ed13495a420ad8641cb2c6c28f9/lib/Support/APFloat.cpp#L4341..L4346