Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_apfloat: fix typo in is_denormal #83725

Closed
wants to merge 1 commit into from

Conversation

@rust-highfive
Copy link
Collaborator

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2021
@jyn514 jyn514 assigned eddyb and unassigned estebank Mar 31, 2021
@eddyb
Copy link
Member

eddyb commented Apr 1, 2021

Looks like this was a porting mistake of mine. But also, we don't even use the PPC code.
I'm torn. A bit weird that tests didn't catch this.

I'll go poke the people dealing with the licensing limbo just to make sure approving this tiny PR won't make anything slightly worse.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2021
@bstrie
Copy link
Contributor

bstrie commented May 19, 2021

@eddyb Per the file that @klensy linked, they derived this change from a file that is licensed under The University of Illinois Open Source License, which means that we should assume this change must be licensed as the same. Since you originally ported rustc-apfloat from a codebase under the same license, this doesn't change anything about the licensing of rustc-apfloat.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021
@Dylan-DPC-zz
Copy link

closing this as there's no much interest in this atm, we can revisit it some other time. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants