-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #83874
Rollup of 8 pull requests #83874
Commits on Mar 22, 2021
-
Add
download-rustc = "if-unchanged"
This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools.
Configuration menu - View commit details
-
Copy full SHA for 7f5964a - Browse repository at this point
Copy the full SHA 7f5964aView commit details
Commits on Apr 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a05892 - Browse repository at this point
Copy the full SHA 8a05892View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72502e8 - Browse repository at this point
Copy the full SHA 72502e8View commit details -
Add
#[inline]
to IpAddr methodsAdd some inlines to trivial methods of IpAddr Closes rust-lang#77583
Configuration menu - View commit details
-
Copy full SHA for a3d0fa8 - Browse repository at this point
Copy the full SHA a3d0fa8View commit details
Commits on Apr 4, 2021
-
Disallow the use of high byte registes as operands on x86_64
They are still allowed on x86 though. Fixes rust-lang#83495
Configuration menu - View commit details
-
Copy full SHA for ba65f37 - Browse repository at this point
Copy the full SHA ba65f37View commit details -
Use the beta compiler for building bootstrap tools when `download-rus…
…tc` is set ## Motivation This avoids having to rebuild bootstrap and tidy each time you rebase over master. In particular, it makes rebasing and running `x.py fmt` on each commit in a branch significantly faster. It also avoids having to rebuild bootstrap after setting `download-rustc = true`. ## Implementation Instead of extracting the CI artifacts directly to `stage0/`, extract them to `ci-rustc/` instead. Continue to copy them to the proper sysroots as necessary for all stages except stage 0. This also requires `bootstrap.py` to download both stage0 and CI artifacts and distinguish between the two when checking stamp files. Note that since tools have to be built by the same compiler that built `rustc-dev` and the standard library, the downloaded artifacts can't be reused when building with the beta compiler. To make sure this is still a good user experience, warn when building with the beta compiler, and default to building with stage 2.
Configuration menu - View commit details
-
Copy full SHA for 14406df - Browse repository at this point
Copy the full SHA 14406dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48f95c1 - Browse repository at this point
Copy the full SHA 48f95c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16444c3 - Browse repository at this point
Copy the full SHA 16444c3View commit details -
Render destructured struct function param names as underscore.
Fixes rust-lang#83852 r? `@GuillaumeGomez`
Configuration menu - View commit details
-
Copy full SHA for 82b2863 - Browse repository at this point
Copy the full SHA 82b2863View commit details -
Don't report disambiguator error if link would have been ignored
This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported.
Configuration menu - View commit details
-
Copy full SHA for 45ccd50 - Browse repository at this point
Copy the full SHA 45ccd50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01be6dd - Browse repository at this point
Copy the full SHA 01be6ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14fac68 - Browse repository at this point
Copy the full SHA 14fac68View commit details
Commits on Apr 5, 2021
-
Use more appropriate return type for
resolve_associated_item
Previously, the types looked like this: - None means this is not an associated item (but may be a variant field) - Some(Err) means this is known to be an error. I think the only way that can happen is if it resolved and but you had your own anchor. - Some(Ok(_, None)) was impossible. Now, this returns a nested Option and does the error handling and fiddling with the side channel in the caller. As a side-effect, it also removes duplicate error handling. This has one small change in behavior, which is that `resolve_primitive_associated_item` now goes through `variant_field` if it fails to resolve something. This is not ideal, but since it will be quickly rejected anyway, I think the performance hit is worth the cleanup. This also fixes a bug where struct fields would forget to set the side channel.
Configuration menu - View commit details
-
Copy full SHA for 3611a64 - Browse repository at this point
Copy the full SHA 3611a64View commit details -
Rollup merge of rust-lang#82739 - jyn514:separate-stage0-stage1, r=Ma…
…rk-Simulacrum Use the beta compiler for building bootstrap tools when `download-rustc` is set ## Motivation This avoids having to rebuild bootstrap and tidy each time you rebase over master. In particular, it makes rebasing and running `x.py fmt` on each commit in a branch significantly faster. It also avoids having to rebuild bootstrap after setting `download-rustc = true`. ## Implementation Instead of extracting the CI artifacts directly to `stage0/`, extract them to `ci-rustc/` instead. Continue to copy them to the proper sysroots as necessary for all stages except stage 0. This also requires `bootstrap.py` to download both stage0 and CI artifacts and distinguish between the two when checking stamp files. Note that since tools have to be built by the same compiler that built `rustc-dev` and the standard library, the downloaded artifacts can't be reused when building with the beta compiler. To make sure this is still a good user experience, warn when building with the beta compiler, and default to building with stage 2. I tested this by rebasing this PR from edeee91 over 1c77a1f and confirming that only the bootstrap library itself had to be rebuilt, not any dependencies and not `tidy`. I also tested that a clean build with `x.py build` builds rustdoc exactly once and does no other work, and that `touch src/librustdoc/lib.rs && x.py build` works. `x.py check` still behaves as before (checks using the beta compiler, even if there are changes to `compiler/`). Helps with rust-lang#81930. r? `@Mark-Simulacrum`
Configuration menu - View commit details
-
Copy full SHA for b8f0d9a - Browse repository at this point
Copy the full SHA b8f0d9aView commit details -
Rollup merge of rust-lang#83368 - jyn514:download-if-unchanged, r=Mar…
…k-Simulacrum Add `download-rustc = "if-unchanged"` This allows keeping the setting to a fixed value without having to toggle it when you want to work on the compiler instead of on tools. This sets `BOOTSTRAP_DOWNLOAD_RUSTC` in bootstrap.py so rustbuild doesn't have to try and replicate its logic. Helps with rust-lang#81930. r? `````@Mark-Simulacrum````` cc `````@camelid`````
Configuration menu - View commit details
-
Copy full SHA for 0d7b32e - Browse repository at this point
Copy the full SHA 0d7b32eView commit details -
Rollup merge of rust-lang#83826 - slightlyoutofphase:rustdoc-sidebar-…
…order-shuffle, r=jyn514 List trait impls before deref methods in doc's sidebar This PR is acting directly on a suggestion made by ````@jyn514```` in rust-lang#83133. I've tested the changes locally, and can confirm that it does in fact properly achieve what he thought it would. This PR also in turn closes rust-lang#83133.
Configuration menu - View commit details
-
Copy full SHA for b706a07 - Browse repository at this point
Copy the full SHA b706a07View commit details -
Rollup merge of rust-lang#83831 - AngelicosPhosphoros:issue-77583-inl…
…ine-for-ip, r=m-ou-se Add `#[inline]` to IpAddr methods Add some inlines to trivial methods of IpAddr Closes rust-lang#77583
Configuration menu - View commit details
-
Copy full SHA for f4f23fc - Browse repository at this point
Copy the full SHA f4f23fcView commit details -
Rollup merge of rust-lang#83849 - jyn514:intra-doc-cleanup, r=bugadani
rustdoc: Cleanup handling of associated items for intra-doc links Helps with rust-lang#83761 (right now the uses of the resolver are all intermingled with uses of the tyctxt). Best reviewed one commit at a time. r? `@bugadani` maybe? Feel free to reassign :)
Configuration menu - View commit details
-
Copy full SHA for 6af263c - Browse repository at this point
Copy the full SHA 6af263cView commit details -
Rollup merge of rust-lang#83853 - Amanieu:asm_no_high_x86_64, r=nagisa
Disallow the use of high byte registes as operands on x86_64 They are still allowed on x86 though. Fixes rust-lang#83495 r? `@nagisa`
Configuration menu - View commit details
-
Copy full SHA for 199bb22 - Browse repository at this point
Copy the full SHA 199bb22View commit details -
Rollup merge of rust-lang#83863 - eggyal:issue-83852, r=jyn514
Render destructured struct function param names as underscore Fixes rust-lang#83852 r? ``@GuillaumeGomez``
Configuration menu - View commit details
-
Copy full SHA for c128993 - Browse repository at this point
Copy the full SHA c128993View commit details -
Rollup merge of rust-lang#83865 - camelid:disamb-err-fix, r=jyn514
Don't report disambiguator error if link would have been ignored Fixes rust-lang#83859. This prevents us from warning on links such as `<hello@example.com>`. Note that we still warn on links such as `<hello@localhost>` because they have no dots in them. However, the links will still work, even though a warning is reported. r? ``@jyn514``
Configuration menu - View commit details
-
Copy full SHA for 32f3dac - Browse repository at this point
Copy the full SHA 32f3dacView commit details