Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ICE when closure is involved in Trait Alias Impl Trait #83954

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Apr 7, 2021

Fix #83613.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2021
@varkor
Copy link
Member

varkor commented Apr 7, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Apr 7, 2021

📌 Commit 18cf44b has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83476 (Add strong_count mutation methods to Rc)
 - rust-lang#83634 (Do not emit the advanced diagnostics on macros)
 - rust-lang#83816 (Trigger `unused_doc_comments` on macros at once)
 - rust-lang#83916 (Use AnonConst for asm! constants)
 - rust-lang#83935 (forbid `impl Trait` in generic param defaults)
 - rust-lang#83936 (Disable using non-ascii identifiers in extern blocks.)
 - rust-lang#83945 (Add suggestion to reborrow mutable references when they're moved in a for loop)
 - rust-lang#83954 (Do not ICE when closure is involved in Trait Alias Impl Trait)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d82419b into rust-lang:master Apr 7, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 7, 2021
illicitonion added a commit to illicitonion/num_enum that referenced this pull request Apr 8, 2021
illicitonion added a commit to illicitonion/num_enum that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: compiler/rustc_trait_selection/src/traits/coherence.rs:600:13: ty_is_local invoked on unexpected type
5 participants