fix Miri errors in libcore doctests #84052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Miri can run doctests, it found some issues in the libcore doctests:
AtomicPtr
tests accessed dangling memory!AtomicPtr::new(&mut 10);
makes the10
a temporary that is deallocated after the end of this expression.set_ptr_value
used&array[0] as *const _
to get a pointer to the array; this needs to bearray.as_ptr()
instead (Cc Stacked Borrows: raw pointer usable only forT
too strict? unsafe-code-guidelines#134).MaybeUninit
test to make it less slow in Miri, and added a spin loop hint to fix a diverging loop in Miri.