Rollup of 7 pull requests #84112
Merged
Rollup of 7 pull requests #84112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly useful for cases where arbitrary self types are used, like in custom `Future`s.
This is the same thing, but simpler.
The lint used to be called `non-autolinks`, and linted more than just bare URLs. Now, it is called `bare-urls` and only lints against bare URLs. So, `bare-urls` is a better name for the test.
This will help us ensure that it emits valid suggestions.
Previously, rustdoc would panic on links to external crates if they were surrounded by backticks.
This groups the similar code together, and also allows making most of collect_intra_doc_links private again
Issue 81508 fix Fix rust-lang#81508 **Problem**: When variable name is used incorrectly as path, error and warning point to undeclared/unused name, when in fact the name is used, just incorrectly (should be used as a variable, not part of a path). **Summary for fix**: When path resolution errs, diagnostics checks for variables in ```ValueNS``` that have the same name (e.g., variable rather than path named Foo), and adds additional suggestion that user may actually intend to use the variable name rather than a path. The fix does not suppress or otherwise change the *warning* that results. I did not find a straightforward way in the code to modify this, but would love to make changes here as well with any guidance.
Improve trait/impl method discrepancy errors * Use more accurate spans * Clean up some code by removing previous hack * Provide structured suggestions Structured suggestions are particularly useful for cases where arbitrary self types are used, like in custom `Future`s, because the way to write `self: Pin<&mut Self>` is not necessarily self-evident when first encountered.
Bump libc dependency of std to 0.2.93 Update `libc` dependency of `std` to the latest version. That allows to consume the rust-lang/libc#2131 fix and fix build for the `mipsel-unknown-linux-uclibc` target. r? `@JohnTitor`
…oshtriplett clean up example on read_to_string This is the same thing, but simpler. This came out of a comment from a user: https://news.ycombinator.com/item?id=25318117 but rather than hide the signature of main, I think a `use` plus not including the `'static` makes more sense.
…yn514 Improve test for `rustdoc::bare_urls` lint - Rename `url-improvements` test to `bare-urls` - Run rustfix for `bare-urls` test
…m-ou-se Remove FixedSizeArray Remove `FixedSizeArray` trait, it has been superseded by const generics. Closes rust-lang#27778.
rustdoc: Move crate loader to collect_intra_doc_links::early This groups the similar code together, and also allows making most of collect_intra_doc_links private again. This builds on rust-lang#84066, but it wouldn't be too hard to base it off master if you want this to land first. Helps with rust-lang#83761. r? manishearth Fixes rust-lang#84046
|
@bors r+ rollup=never p=5 |
|
📌 Commit 1ff117e has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustdoc::bare_urlslint #84079 (Improve test forrustdoc::bare_urlslint)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup