-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #84368
Rollup of 5 pull requests #84368
Commits on Mar 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 30fc601 - Browse repository at this point
Copy the full SHA 30fc601View commit details -
Configuration menu - View commit details
-
Copy full SHA for 321aace - Browse repository at this point
Copy the full SHA 321aaceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7faaf39 - Browse repository at this point
Copy the full SHA 7faaf39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 789186d - Browse repository at this point
Copy the full SHA 789186dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2acd8eb - Browse repository at this point
Copy the full SHA 2acd8ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e34eb8 - Browse repository at this point
Copy the full SHA 3e34eb8View commit details
Commits on Apr 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 539242a - Browse repository at this point
Copy the full SHA 539242aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eea27b8 - Browse repository at this point
Copy the full SHA eea27b8View commit details
Commits on Apr 20, 2021
-
rustdoc: use details tag for trait implementors
This switches from JS-generated toggles to using the HTML <details> tag for expanding and collapsing entries in the "Implementors" section.
Configuration menu - View commit details
-
Copy full SHA for 569096c - Browse repository at this point
Copy the full SHA 569096cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e85f19b - Browse repository at this point
Copy the full SHA e85f19bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cc918a - Browse repository at this point
Copy the full SHA 8cc918aView commit details -
Rollup merge of rust-lang#83004 - sunjay:field-never-read-issue-81658…
…, r=pnkfelix Improve diagnostic for when field is never read Related to (but does not close) rust-lang#81658 This completes the first step of `@pnkfelix's` [mentoring instructions](rust-lang#81658 (comment)) but does not actually improve the diagnostics (yet!). The two tests are heavily reduced versions of code from the original bug report. I've confirmed that the reduced `field-used-in-ffi` test [fails on nightly](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a) but [passes on stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a). This confirms that the regression is reproduced correctly. The `drop-only-field` test is a case that `@pnkfelix` mentioned in his mentoring instructions. It is not a regression, but will come in handy when we make the diagnostic smarter by looking at whether the field type implements `Drop`. Per the [rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/tests/adding.html), each test includes a comment summarizing what it is about.
Configuration menu - View commit details
-
Copy full SHA for 7f561d8 - Browse repository at this point
Copy the full SHA 7f561d8View commit details -
Rollup merge of rust-lang#83729 - JohnTitor:issue-43913, r=estebank
Add a suggestion when using a type alias instead of trait alias Fixes rust-lang#43913 r? `@estebank`
Configuration menu - View commit details
-
Copy full SHA for 4e43d20 - Browse repository at this point
Copy the full SHA 4e43d20View commit details -
Rollup merge of rust-lang#84320 - jsha:details-implementors, r=Manish…
…earth,Nemo157,GuillaumeGomez Use details tag for trait implementors. Part of rust-lang#83332 and following on from rust-lang#83337 and rust-lang#83355. This removes one category of JS-generated toggles (implementors), and replaces them with a `<details>` tag. This simplifies the JS, and fixes some bugs where things that were supposed to be hidden by the toggle were not hidden. Compare https://hoffman-andrews.com/rust/details-implementors/std/io/trait.Read.html#impl-Read vs https://doc.rust-lang.org/nightly/std/io/trait.Read.html#implementors. This introduces a `left: -23px` to put the toggle in the correct place, matching the current style for `.collapse-toggle`. It's worth noting this introduces a slight behavior change: since the entire line is now a `<summary>`, any part of the line is clickable. So for instance, in `impl Read for File`, clicking `impl` or `for` will collapse / expand the docs. Clicking `Read` or `File` still links to the appropriate documentation as before.
Configuration menu - View commit details
-
Copy full SHA for c8e7052 - Browse repository at this point
Copy the full SHA c8e7052View commit details -
Rollup merge of rust-lang#84359 - lnicola:rust-analyzer-2021-04-20, r…
…=jonas-schievink ⬆️ rust-analyzer
Configuration menu - View commit details
-
Copy full SHA for d6a2b03 - Browse repository at this point
Copy the full SHA d6a2b03View commit details -
Rollup merge of rust-lang#84365 - vext01:improve-lto-docstrings, r=pe…
…trochenkov Improve the docstrings of the `Lto` struct. This change is the result of [this zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Making.20sense.20of.20LTO.20modes.20in.20rustc). Hopefully it makes things a little clearer. What do you think?
Configuration menu - View commit details
-
Copy full SHA for b58e1f2 - Browse repository at this point
Copy the full SHA b58e1f2View commit details