-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use arrayvec 0.7, drop smallvec 0.6 #84420
Conversation
With the arrival of min const generics, many alt-vec libraries have updated to use it in some way and arrayvec is no exception. Use the latest with minor refactoring. Also, rustc_workspace_hack is the only user of smallvec 0.6 in the entire tree, so drop it.
(rust-highfive has picked a reviewer for you, use r? to override) |
With arrayvec updates there was some issues with performance, so i guess it's better to do a perf run? |
@bors try @rust-timer queue I wouldn't expect any difference, but we can definitely check. |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit e8eb691 with merge 8663640101c59d348cf2968c0d02ff47966bcc6e... |
☀️ Try build successful - checks-actions |
Queued 8663640101c59d348cf2968c0d02ff47966bcc6e with parent 88b99de, future comparison URL. |
Finished benchmarking try commit (8663640101c59d348cf2968c0d02ff47966bcc6e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Looks like some potential gains and some potential very small losses but mostly noise? I'm not the most experienced here at reading these tea leaves, though. |
Seems overall fine. @bors r+ |
📌 Commit e8eb691 has been approved by |
☀️ Test successful - checks-actions |
With the arrival of min const generics, many alt-vec libraries have
updated to use it in some way and arrayvec is no exception. Use the
latest with minor refactoring.
Also, rustc_workspace_hack is the only user of smallvec 0.6 in the
entire tree, so drop it.