Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arrayvec 0.7, drop smallvec 0.6 #84420

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

workingjubilee
Copy link
Member

With the arrival of min const generics, many alt-vec libraries have
updated to use it in some way and arrayvec is no exception. Use the
latest with minor refactoring.

Also, rustc_workspace_hack is the only user of smallvec 0.6 in the
entire tree, so drop it.

With the arrival of min const generics, many alt-vec libraries have
updated to use it in some way and arrayvec is no exception. Use the
latest with minor refactoring.

Also, rustc_workspace_hack is the only user of smallvec 0.6 in the
entire tree, so drop it.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2021
@klensy
Copy link
Contributor

klensy commented Apr 22, 2021

With arrayvec updates there was some issues with performance, so i guess it's better to do a perf run?

@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

I wouldn't expect any difference, but we can definitely check.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 22, 2021
@bors
Copy link
Contributor

bors commented Apr 22, 2021

⌛ Trying commit e8eb691 with merge 8663640101c59d348cf2968c0d02ff47966bcc6e...

@bors
Copy link
Contributor

bors commented Apr 22, 2021

☀️ Try build successful - checks-actions
Build commit: 8663640101c59d348cf2968c0d02ff47966bcc6e (8663640101c59d348cf2968c0d02ff47966bcc6e)

@rust-timer
Copy link
Collaborator

Queued 8663640101c59d348cf2968c0d02ff47966bcc6e with parent 88b99de, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8663640101c59d348cf2968c0d02ff47966bcc6e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 22, 2021
@workingjubilee
Copy link
Member Author

Looks like some potential gains and some potential very small losses but mostly noise? I'm not the most experienced here at reading these tea leaves, though.

@Mark-Simulacrum
Copy link
Member

Seems overall fine.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 22, 2021

📌 Commit e8eb691 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2021
@bors
Copy link
Contributor

bors commented Apr 22, 2021

⌛ Testing commit e8eb691 with merge 7f4afdf...

@bors
Copy link
Contributor

bors commented Apr 22, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7f4afdf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2021
@bors bors merged commit 7f4afdf into rust-lang:master Apr 22, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 22, 2021
@workingjubilee workingjubilee deleted the microvec branch April 23, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants