Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

84304 - rustdoc: shrink Item::Attributes #84494

Merged
merged 2 commits into from
Apr 27, 2021
Merged

84304 - rustdoc: shrink Item::Attributes #84494

merged 2 commits into from
Apr 27, 2021

Commits on Apr 27, 2021

  1. Removed usage of Attributes in FnDecl and ExternalCrate. Relocate par… 

    …t of the fields in Attributes, as functions in AttributesExt.

refacto use from_def_id_and_attrs_and_parts instead of an old trick

most of josha suggestions + check if def_id is not fake before using it in a query

Removed usage of Attributes in FnDecl and ExternalCrate. Relocate part of the Attributes fields as functions in AttributesExt.
    Timothée Delabrouille committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    b4f1dfd View commit details
    Browse the repository at this point in the history

  2. cfg taken out of Attributes, put in Item 

    check item.is_fake() instead of self_id.is_some()

Remove empty branching in Attributes::from_ast

diverse small refacto after Josha review

cfg computation moved in merge_attrs

refacto use from_ast twice for coherence

take cfg out of Attributes and move it to Item
    Timothée Delabrouille committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    727f904 View commit details
    Browse the repository at this point in the history