-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary CSS rules for search results #84688
Remove unnecessary CSS rules for search results #84688
Conversation
Some changes occurred in HTML/CSS/JS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested deleting this rule on random builds from 2016/2017/2018/2019 too, and they appear to work.
I'll still need to override for docs.rs fix but in the meantime, it'll be less CSS on rustdoc. :) Thanks for the quick review! @bors: r=Nemo157 rollup |
📌 Commit 8c04695 has been approved by |
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? `@Nemo157`
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ``@Nemo157``
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ```@Nemo157```
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ````@Nemo157````
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? `````@Nemo157`````
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ``````@Nemo157``````
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ```````@Nemo157```````
Rollup of 10 pull requests Successful merges: - rust-lang#84451 (Use flex more consistently) - rust-lang#84590 (Point out that behavior might be switched on 2015 and 2018 too one day) - rust-lang#84682 (Don't rebind in `transitive_bounds_that_define_assoc_type`) - rust-lang#84683 (Minor grammar tweaks for readability to btree internals) - rust-lang#84688 (Remove unnecessary CSS rules for search results) - rust-lang#84690 (Remove unneeded bottom margin on search results) - rust-lang#84692 (Link between std::env::{var, var_os} and std::env::{vars, vars_os}) - rust-lang#84705 (make feature recommendations optional) - rust-lang#84706 (Drop alias `reduce` for `fold` - we have a `reduce` function) - rust-lang#84713 (Fix labels for regression issue template) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Discovered that this was useless when working on rust-lang/docs.rs#1382.
r? @Nemo157