Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR 77885 everywhere #84708

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Revert PR 77885 everywhere #84708

merged 2 commits into from
Apr 29, 2021

Commits on Apr 29, 2021

  1. Change to probe-stack=call (instead of inline-or-call) everywhere aga… 

    …in, for now.

We had already reverted the change on stable back in PR rust-lang#83412.

Since then, we've had some movement on issue rust-lang#83139, but not a 100% fix.

But also since then, we had bug reported, issue rust-lang#84667, that looks like outright
codegen breakage, rather than problems confined to debuginfo issues.

So we are reverting PR rust-lang#77885 on stable and beta. We'll reland PR rust-lang#77885 (or some
variant) switching back to an LLVM-dependent selection of out-of-line call vs
inline-asm, after these other issues have been resolved.
    @pnkfelix
    pnkfelix committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    8d1083e View commit details
    Browse the repository at this point in the history

  2. Remove tests introduced or cahnged by PR rust-lang#77885, which is re… 

    …verted in this PR.
    @pnkfelix
    pnkfelix committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    db4c544 View commit details
    Browse the repository at this point in the history