Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode spans relative to the enclosing item -- enable on nightly #84762

Merged
merged 8 commits into from
Jan 2, 2023
Merged

Encode spans relative to the enclosing item -- enable on nightly #84762

merged 8 commits into from
Jan 2, 2023

Commits on Dec 25, 2022

  1. Encode span parent in the inlined representation.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    6d42636 View commit details
    Browse the repository at this point in the history

  2. Mark incremental-ignore-spans as TRACKED. 

    Using that options basically changes all stable hashes we may compute.
Adding/removing as UNTRACKED it makes everything ICE (unstable fingerprint
everywhere).  As TRACKED, it can still do its job without ICEing.
    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    44972b2 View commit details
    Browse the repository at this point in the history

  3. Use absolute spans when trying to steal an AST diagnostic.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    66e0316 View commit details
    Browse the repository at this point in the history

  4. Enable relative span hashing.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    65f342d View commit details
    Browse the repository at this point in the history

  5. Only enable relative span hashing on nightly.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    40c8165 View commit details
    Browse the repository at this point in the history

  6. Ignore span references from diagnostics. 

    The diagnostics are replayed at the correct place anyway.
    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    4719cb3 View commit details
    Browse the repository at this point in the history

  7. Remove references to removed option from tests.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    5b9360b View commit details
    Browse the repository at this point in the history

  8. Explain disabled span hashing.

    @cjgillot
    cjgillot committed Dec 25, 2022
    Configuration menu
    Copy the full SHA
    7b6ead2 View commit details
    Browse the repository at this point in the history