-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Don't require building a stage1 compiler before running cargotest #84780
Conversation
This allows running a single test without having to wait for all tests to complete.
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Always use a bootstrap compiler for cargo and cargo-credential helpers This seems wrong; I think cargo is intentionally built with stage 2 because it's distributed with other parts of the release. However, I don't know how to avoid it - just changing CargoTest to build it with stage 0 unconditionally still builds rustc because it uses a `ToolRustc` mode. - Don't call `builder.ensure(Rustc)`. It's unnecessary. - Don't use the same compiler for building cargo as for testing.
The job Click to see the possible cause of the failure (guessed by this bot)
|
Some of Cargo's tests require rustc to be built, so we'll want to make sure rustc is available there. Regardless though I expect almost no one to run cargo tests in-tree and I imagine the download-rustc support is pretty likely sufficient for those who do? I may be missing the motivation for this. I think we could move Cargo itself to a Std tool, rather than a Rustc tool, but I think your PR description is accurate to say Bootstrap tool is wrong.
|
Yeah, I don't think this is super useful and it seems complicated. |
Always use a bootstrap compiler for cargo and cargo-credential helpers
This seems wrong; I think cargo is intentionally built with stage 2
because it's distributed with other parts of the release. However, I
don't know how to avoid it - just changing CargoTest to build it with
stage 0 unconditionally still builds rustc because it uses a
ToolRustc
mode.
Don't call
builder.ensure(Rustc)
. It's unnecessary.Don't use the same compiler for building cargo as for testing.
Builds on #84779 to avoid merge conflicts.