Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mir-Opt for copying enums with large discrepancies #85158

Merged
merged 9 commits into from
Feb 11, 2023

Commits on Feb 7, 2023

  1. Configuration menu
    Copy the full SHA
    18144b6 View commit details
    Browse the repository at this point in the history
  2. Add comments

    Still need to make it so that it maps discriminants to variant indexes.
    Maybe instead I can map the variant indexes to discriminants?
    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    96db5e9 View commit details
    Browse the repository at this point in the history
  3. Clean up MIR transform

    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    33b4d20 View commit details
    Browse the repository at this point in the history
  4. Update with comments

    Changing a bunch of struct constructors to `from`, no extra destructuring,
    getting the type of the discriminant.
    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    f7cbf2e View commit details
    Browse the repository at this point in the history
  5. Set mir-opt-level = 0 on some codegen tests

    Since we're changing a bunch of stuff, necessary to remove some codegen tests
    which look for specific things. Also attempting to restart a test which timed out, maybe due to
    fastly failing?
    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3e97cef View commit details
    Browse the repository at this point in the history
  6. Rm allocation in candidate

    Instead of storing an extra array for discriminant values, create an allocation there and store
    those in an allocation immediately.
    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5d9f514 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    610e1a1 View commit details
    Browse the repository at this point in the history
  8. Leave FIXME for wasm layout difference.

    There is a distinction between running this on wasm and i686, even though they should be
    identical. This technically is not _incorrect_, it's just an unexpected difference, which is
    worth investigating, but not for correctness.
    JulianKnodt committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    15f4eec View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Configuration menu
    Copy the full SHA
    15d4728 View commit details
    Browse the repository at this point in the history