-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mir-Opt for copying enums with large discrepancies #85158
Merged
Merged
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18144b6 - Browse repository at this point
Copy the full SHA 18144b6View commit details -
Still need to make it so that it maps discriminants to variant indexes. Maybe instead I can map the variant indexes to discriminants?
Configuration menu - View commit details
-
Copy full SHA for 96db5e9 - Browse repository at this point
Copy the full SHA 96db5e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33b4d20 - Browse repository at this point
Copy the full SHA 33b4d20View commit details -
Changing a bunch of struct constructors to `from`, no extra destructuring, getting the type of the discriminant.
Configuration menu - View commit details
-
Copy full SHA for f7cbf2e - Browse repository at this point
Copy the full SHA f7cbf2eView commit details -
Set mir-opt-level = 0 on some codegen tests
Since we're changing a bunch of stuff, necessary to remove some codegen tests which look for specific things. Also attempting to restart a test which timed out, maybe due to fastly failing?
Configuration menu - View commit details
-
Copy full SHA for 3e97cef - Browse repository at this point
Copy the full SHA 3e97cefView commit details -
Instead of storing an extra array for discriminant values, create an allocation there and store those in an allocation immediately.
Configuration menu - View commit details
-
Copy full SHA for 5d9f514 - Browse repository at this point
Copy the full SHA 5d9f514View commit details -
Configuration menu - View commit details
-
Copy full SHA for 610e1a1 - Browse repository at this point
Copy the full SHA 610e1a1View commit details -
Leave FIXME for wasm layout difference.
There is a distinction between running this on wasm and i686, even though they should be identical. This technically is not _incorrect_, it's just an unexpected difference, which is worth investigating, but not for correctness.
Configuration menu - View commit details
-
Copy full SHA for 15f4eec - Browse repository at this point
Copy the full SHA 15f4eecView commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 15d4728 - Browse repository at this point
Copy the full SHA 15d4728View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.