Rustdoc cleanup #85175
Merged
Rustdoc cleanup #85175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
C-cleanup
|
Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
notriddle
reviewed
May 12, 2021
| @@ -600,7 +596,6 @@ fn item_trait(w: &mut Buffer, cx: &Context<'_>, it: &clean::Item, t: &clean::Tra | |||
| for t in types { | |||
| trait_item(w, cx, t, it); | |||
| } | |||
| write_loading_content(w, "</div>"); | |||
There was a problem hiding this comment.
The </div> itself still need to be there, doesn't it?
There was a problem hiding this comment.
Indeed, good catch!
jsha
reviewed
May 12, 2021
There was a problem hiding this comment.
Generally looks good to me, though I concur with @notriddle's observation that we still need those </divs>.
GuillaumeGomez
force-pushed
the
rustdoc-cleanup
branch
from
eaed4c6
to
cb91c6f
Compare
|
Fixed @notriddle's comment! |
|
@bors r+ |
|
📌 Commit cb91c6f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 13, 2021
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#85068 (Fix diagnostic for cross crate private tuple struct constructors) - rust-lang#85175 (Rustdoc cleanup) - rust-lang#85177 (add BITS associated constant to core::num::Wrapping) - rust-lang#85240 (Don't suggest adding `'static` lifetime to arguments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #83332. The goal of this PR is to remove a few unused things:
r? @jsha