Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #85199

Merged
merged 34 commits into from
May 12, 2021
Merged

Rollup of 8 pull requests #85199

merged 34 commits into from
May 12, 2021

Commits on May 7, 2021

  1. Configuration menu
    Copy the full SHA
    f6dd332 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. Address comments

    Rustin170506 committed May 8, 2021
    Configuration menu
    Copy the full SHA
    7c5bc20 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Configuration menu
    Copy the full SHA
    0778e8d View commit details
    Browse the repository at this point in the history
  2. Fix typo in variable name

    All other sibling functions call this variable "slot", so "slote" was most likely a typo.
    LingMan committed May 10, 2021
    Configuration menu
    Copy the full SHA
    41779f6 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Configuration menu
    Copy the full SHA
    f740923 View commit details
    Browse the repository at this point in the history
  2. rustdoc: Show basic type layout information

    Right now it just shows the size.
    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    001f0dd View commit details
    Browse the repository at this point in the history
  3. Remove FIXME

    Layout errors can occur with valid code, e.g. generic types.
    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    5859c5d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20b30ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9859e2b View commit details
    Browse the repository at this point in the history
  6. Show memory layout for type aliases

    At first you might think "why not just click through to the aliased
    type?", but if a type alias instantiates all of the generic parameters
    of the aliased type, then it can show layout info even though the
    aliased type cannot (because we can't compute the layout of a generic
    type). So I think it's still useful to show layout info for type
    aliases.
    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    48da66f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    12ee920 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9615d6d View commit details
    Browse the repository at this point in the history
  9. Fix a few small things

    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    db3a06d View commit details
    Browse the repository at this point in the history
  10. Add tcx local variable

    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    8048c70 View commit details
    Browse the repository at this point in the history
  11. Apply suggestions from code review

    Co-authored-by: Ivan Tham <pickfire@riseup.net>
    camelid and pickfire committed May 11, 2021
    Configuration menu
    Copy the full SHA
    bcbc727 View commit details
    Browse the repository at this point in the history
  12. Make test more specific

    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    61a8479 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    879a914 View commit details
    Browse the repository at this point in the history
  14. Add note to docs when layout cannot be computed

    This should prevent confusion about why generic types don't have layout
    docs.
    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    8b9298b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    9b89d01 View commit details
    Browse the repository at this point in the history
  16. Disable layout docs for type aliases for now

    There are issues with computing layout for type aliases; see rust-lang#85103.
    Once the issues are fixed, we should re-enable layout docs for them.
    camelid committed May 11, 2021
    Configuration menu
    Copy the full SHA
    d43701c View commit details
    Browse the repository at this point in the history
  17. rustdoc: remove explicit boolean comparisons.

    For boolean variables it's shorter and more readable to check the value
    directly, or negate it with `!`.
    
    In a couple of cases I reordered an if/else pair because it made the
    initial `if` statement simpler.
    
    Removed unused isType parameter from two functions.
    jsha committed May 11, 2021
    Configuration menu
    Copy the full SHA
    f510e41 View commit details
    Browse the repository at this point in the history
  18. Move rustdoc-gui rust libraries into their own folder and prepare the…

    … field for more libraries
    GuillaumeGomez committed May 11, 2021
    Configuration menu
    Copy the full SHA
    d5a24b0 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    1b0976c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6b94990 View commit details
    Browse the repository at this point in the history
  21. Revert "Auto merge of rust-lang#84797 - richkadel:cover-unreachable-s…

    …tatements, r=tmandry"
    
    This reverts commit e5f83d2, reversing
    changes made to ac888e8.
    richkadel committed May 11, 2021
    Configuration menu
    Copy the full SHA
    bea112b View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    69a4ae2 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#83501 - camelid:rustdoc-layout, r=jyn514,Gu…

    …illaumeGomez
    
    rustdoc: Add unstable CLI option to show basic type layout information
    
    Closes rust-lang#75988.
    
    Right now it just shows the size.
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    40be1d3 View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#85018 - hi-rustin:rustin-patch-84637, r=est…

    …ebank
    
    shrinking the deprecated method span
    
    close rust-lang#84637
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    649b385 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#85124 - jsha:trust-the-bool, r=GuillaumeGomez

    rustdoc: remove explicit boolean comparisons.
    
    For boolean variables it's shorter and more readable to check the value directly, or negate it with `!`.
    
    In a couple of cases I reordered an if/else pair because it made the initial `if` statement simpler.
    
    An example of a style guide recommending this: https://airbnb.io/javascript/#comparison--shortcuts
    
    r? `@GuillaumeGomez`
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    4ab3050 View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#85136 - shirshak55:master, r=dtolnay

    Change param name (k to key and v to value) in std::env module
    
    1. When I was reading code the ide displayed `k` and `v`, so I
    thought it would be better to show key and value?
    
    2. I noticed var method already uses `key` instead of `k` so it
    is more consistent to use `key` instead of `k`?
    
    Thanks
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    6ec4f91 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#85162 - LingMan:patch-1, r=varkor

    Fix typo in variable name
    
    All other sibling functions call this variable "slot", so "slote" was most likely a typo.
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    9ad5c4d View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#85187 - FabianWolff:issue-84976, r=jackh726

    Use .name_str() to format primitive types in error messages
    
    This pull request fixes rust-lang#84976. The problem described there is caused by this code
    https://github.com/rust-lang/rust/blob/506e75cbf8cb5305e49a41326307004ca3976029/compiler/rustc_middle/src/ty/error.rs#L161-L166
    using `Debug` formatting (`{:?}`), while the proper solution is to call `name_str()` of `ty::IntTy`, `ty::UintTy` and `ty::FloatTy`, respectively.
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c4c654f View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#85191 - GuillaumeGomez:improve-rustdoc-gui-…

    …tester, r=Mark-Simulacrum
    
    Improve rustdoc gui tester
    
    I cherry-picked the commit from rust-lang#84834 (and modified it a bit). I also used this opportunity to update it to last version (forgot to update GUI test in rust-lang#85074, really can't wait to make rust-lang#84586 finally work).
    
    cc `@Mark-Simulacrum` for the changes in bootstrap.
    
    r? `@jsha`
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    8f3c2cc View commit details
    Browse the repository at this point in the history
  30. Rollup merge of rust-lang#85196 - richkadel:reverts-cover-unreachable…

    …-statements, r=tmandry
    
    Revert "Auto merge of rust-lang#84797 - richkadel:cover-unreachable-statements…
    
    This reverts commit e5f83d2, reversing
    changes made to ac888e8.
    
    See rust-lang#84797 (comment)
    
    r? `@tmandry`
    JohnTitor committed May 11, 2021
    Configuration menu
    Copy the full SHA
    e27f20a View commit details
    Browse the repository at this point in the history