Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning cache key #85436

Merged
merged 2 commits into from
Jun 6, 2021
Merged

Avoid cloning cache key #85436

merged 2 commits into from
Jun 6, 2021

Conversation

tamird
Copy link
Contributor

@tamird tamird commented May 18, 2021

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2021
@tamird tamird mentioned this pull request May 18, 2021
Merged
@bstrie bstrie added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2021
@tamird
Copy link
Contributor Author

tamird commented Jun 4, 2021

@estebank ping

@estebank
Copy link
Contributor

estebank commented Jun 5, 2021

@bors r+ rollup

Sorry for the delay!

@bors
Copy link
Contributor

bors commented Jun 5, 2021

📌 Commit 42b9d3f has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 6, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2021
@bors
Auto merge of rust-lang#86054 - JohnTitor:rollup-j40z7sm, r=JohnTitor
f57d5ba 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85436 (Avoid cloning cache key)
 - rust-lang#85772 (Preserve metadata w/ Solaris-like linkers.)
 - rust-lang#85920 (Tweak wasm_base target spec to indicate linker is not GNU and update linker inferring logic for wasm-ld.)
 - rust-lang#85930 (Update standard library for IntoIterator implementation of arrays )
 - rust-lang#85972 (Rustdoc html fixes)
 - rust-lang#86028 (Drop an `if let` that will always succeed)
 - rust-lang#86043 (don't clone attrs)
 - rust-lang#86047 (Don't fire `invalid_doc_attributes` on `extern crate` items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b3bcf4a into rust-lang:master Jun 6, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 6, 2021
@tamird tamird deleted the save-clone branch June 6, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingMan LingMan LingMan left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tamird @estebank @bors @LingMan @bstrie @rust-highfive @rustbot