Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stdarch to fix x86 byte shift intrinsics #85493

Merged
merged 1 commit into from
May 20, 2021
Merged

Update stdarch to fix x86 byte shift intrinsics #85493

merged 1 commit into from
May 20, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented May 20, 2021

Fixes #85446

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2021
@dtolnay
Copy link
Member

dtolnay commented May 20, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2021

📌 Commit d4a0bcc has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2021
@marmeladema
Copy link
Contributor

Should there be a test added? If so, would it be in stdarch or in rustc?

@Aaron1011
Copy link
Member

@bors p=1 (fixes P-critical issue).

@bors
Copy link
Contributor

bors commented May 20, 2021

⌛ Testing commit d4a0bcc with merge 9a3214e...

@bors
Copy link
Contributor

bors commented May 20, 2021

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 9a3214e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2021
@bors bors merged commit 9a3214e into rust-lang:master May 20, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

Regression on nightly in AVX2 byte shift intrinsics
7 participants
@Amanieu @rust-highfive @dtolnay @bors @marmeladema @Aaron1011 @rustbot