Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #85588

Merged
merged 11 commits into from
May 23, 2021
Merged

[beta] backports #85588

merged 11 commits into from
May 23, 2021

Commits on May 22, 2021

  1. backport 1.52.1 release notes

    @pietroalbini @Mark-Simulacrum
    pietroalbini authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    5a2dbd0 View commit details
    Browse the repository at this point in the history

  2. remove InPlaceIterable marker from Peekable due to unsoundness 

    The unsoundness is not in Peekable per se, it rather is due to the
interaction between Peekable being able to hold an extra item
and vec::IntoIter's clone implementation shortening the allocation.

An alternative solution would be to change IntoIter's clone implementation
to keep enough spare capacity available.
    @the8472 @Mark-Simulacrum
    the8472 authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    586b51a View commit details
    Browse the repository at this point in the history

  3. add regression test

    @the8472 @Mark-Simulacrum
    the8472 authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    c47274b View commit details
    Browse the repository at this point in the history

  4. from review: more robust test 

    This also checks the contents and not only the capacity in case IntoIter's clone implementation is changed to add capacity at the end. Extra capacity at the beginning would be needed to make InPlaceIterable work.

Co-authored-by: Giacomo Stevanato <giaco.stevanato@gmail.com>
    @the8472 @SkiFire13 @Mark-Simulacrum
    2 people authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    ff346b9 View commit details
    Browse the repository at this point in the history

  5. Call initSidebarItems in root module of crate

    @Stupremee @Mark-Simulacrum
    Stupremee authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    855a573 View commit details
    Browse the repository at this point in the history

  6. Synchronize llvm to master commit

    @Mark-Simulacrum
    Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    5d1125d View commit details
    Browse the repository at this point in the history

  7. Do not ICE on invalid const param 

    When encountering a path that can't have generics, do not call
`generics_of`. This would happen when writing something like
`path::this_is_a_mod<const_val>`.

Fix rust-lang#84831.
    @estebank @Mark-Simulacrum
    estebank authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    e68af12 View commit details
    Browse the repository at this point in the history

  8. Disallows #![feature(no_coverage)] on stable and beta 

    using allow_internal_unstable (as recommended)

Fixes: rust-lang#84836

```shell
$ ./build/x86_64-unknown-linux-gnu/stage1/bin/rustc     src/test/run-make-fulldeps/coverage/no_cov_crate.rs
error[E0554]: `#![feature]` may not be used on the dev release channel
 --> src/test/run-make-fulldeps/coverage/no_cov_crate.rs:2:1
  |
2 | #![feature(no_coverage)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0554`.
```
    @richkadel @Mark-Simulacrum
    richkadel authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    d1e2499 View commit details
    Browse the repository at this point in the history

  9. Ensure TLS destructors run before thread joins in SGX

    @mzohreva @Mark-Simulacrum
    mzohreva authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    c297d1e View commit details
    Browse the repository at this point in the history

  10. Use atomics in join_orders_after_tls_destructors test 

    std::sync::mpsc uses thread locals and depending on the order TLS dtors
are run `rx.recv()` can panic when used in a TLS dtor.
    @mzohreva @Mark-Simulacrum
    mzohreva authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    5d1fdf4 View commit details
    Browse the repository at this point in the history

  11. join_orders_after_tls_destructors: ensure thread 2 is launched before… 

    … thread 1 enters TLS destructors
    @mzohreva @Mark-Simulacrum
    mzohreva authored and Mark-Simulacrum committed May 22, 2021
    Configuration menu
    Copy the full SHA
    0e49ff0 View commit details
    Browse the repository at this point in the history