Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Benchmark unconditional incr. comp. fingerprint verification #85784

Closed

Conversation

michaelwoerister
Copy link
Member

Let's see how big the slowdown is compared to the current state of things.

cc #85783

r? @ghost

@michaelwoerister
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2021
@bors
Copy link
Contributor

bors commented May 28, 2021

⌛ Trying commit 563792d with merge 8eb79e7ec566e6f8e30472424c90de8287d53c3e...

@bors
Copy link
Contributor

bors commented May 28, 2021

☀️ Try build successful - checks-actions
Build commit: 8eb79e7ec566e6f8e30472424c90de8287d53c3e (8eb79e7ec566e6f8e30472424c90de8287d53c3e)

@rust-timer
Copy link
Collaborator

Queued 8eb79e7ec566e6f8e30472424c90de8287d53c3e with parent ce0d64e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8eb79e7ec566e6f8e30472424c90de8287d53c3e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 28, 2021
@Mark-Simulacrum
Copy link
Member

death checking seems to at least be a common piece of self-profile results showing regressions across the top few benchmarks -- I wonder if there's some local optimizations that can be made (e.g., making queries no_hash or something, I don't remember the names of the attributes too well) to avoid some of the cost here.

@michaelwoerister michaelwoerister removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2021
@michaelwoerister
Copy link
Member Author

I'll use the benchmark results collected here for proposing a design meeting about increasing test coverage. Closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants