Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Reduce the amount of untracked state in TyCtxt" #85884

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Revert "Reduce the amount of untracked state in TyCtxt" #85884

merged 1 commit into from
Jun 1, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 1, 2021 •
edited by RalfJung
Loading

Reverts #85153
Fixes #85878

The performance hit is massive, and was not visible in the in-review perf run.

r? @Aaron1011

@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@michaelwoerister
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 1, 2021

📌 Commit 0f0f313 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2021
@michaelwoerister
Copy link
Member

Here's the perf run for reference: https://perf.rust-lang.org/compare.html?start=d2091147b16a1e3e1f9a73b6ee29fbe941c8abce&end=41278062c8399ac02ed281e8b1648b99a36942e6&stat=instructions:u

@michaelwoerister
Copy link
Member

It would be great if we could get StableVec removed again asap 😃

@bors
Copy link
Contributor

bors commented Jun 1, 2021

⌛ Testing commit 0f0f313 with merge 1160cf8...

@bors
Copy link
Contributor

bors commented Jun 1, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 1160cf8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2021
@bors bors merged commit 1160cf8 into master Jun 1, 2021
@bors bors deleted the revert-85153-qresolve branch June 1, 2021 12:10
@rustbot rustbot added this to the 1.54.0 milestone Jun 1, 2021
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #85884!

Tested on commit 1160cf8.
Direct link to PR: #85884

🎉 miri on windows: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 1, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#85884!
78b6db9 
Tested on commit rust-lang/rust@1160cf8.
Direct link to PR: <rust-lang/rust#85884>

🎉 miri on windows: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @eddyb @oli-obk @RalfJung).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#85153
6 participants
@cjgillot @rust-highfive @michaelwoerister @bors @Aaron1011 @rustbot