Bufwriter disassembly tweaks #85901
Merged
Bufwriter disassembly tweaks #85901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ijackson
force-pushed
the
bufwriter-tweaks
branch
from
1f6ba65
to
ad88a43
Compare
3 tasks
crlf0710
added
S-waiting-on-review
joshtriplett
reviewed
Jul 2, 2021
ijackson
force-pushed
the
bufwriter-tweaks
branch
from
ad88a43
to
51d16ac
Compare
ijackson
added a commit
to ijackson/rust
that referenced
this pull request
Jul 19, 2021
As requested rust-lang#85901 (review) Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
|
Rebased onto current master. |
|
Thanks for implementing the rename! @bors r+ |
|
📌 Commit 51d16ac has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 28, 2021
…iplett Bufwriter disassembly tweaks In rust-lang#80690 `@BurntSushi` observed that `WriterPanicked` was erroneously not exported, and suggested renaming `into_raw_parts` to `into_parts`. (More info in my commit messages.) r? `@BurntSushi`
|
Failed in rollup: #87567 (comment) |
bors
added
S-waiting-on-author
|
@JohnTitor Oh dear. Sorry, this seems rather messed up I'm a bit full of wine now :-) but I will look at it properly tomorrow. |
I didn't notice the submodule, which means I failed to re-export this to make it actually-public. Reported-by: Andrew Gallant <jamslam@gmail.com> Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
I looked in stdlib and as @BurntSushi thought, `raw` is generally used for raw pointers, or other hazardous kinds of thing. stdlib does not have `into_parts` apart from the one I added to `IntoInnerError`. I did an ad-hoc search of the rustdocs for my current game project Otter, which includes quite a large number of dependencies. `into_parts` seems heavily used for things quite like this. So change this name. Suggested-by: Andrew Gallant <jamslam@gmail.com> Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
As requested rust-lang#85901 (review) Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
ijackson
force-pushed
the
bufwriter-tweaks
branch
from
51d16ac
to
bf30c51
Compare
|
Oh I see, 8837bf1 introduced a use of OK, Rebased and fixed. I also double checked the docs and they do look like everything is properly exported. |
|
Thanks! |
|
📌 Commit bf30c51 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 29, 2021
…iplett Bufwriter disassembly tweaks In rust-lang#80690 `@BurntSushi` observed that `WriterPanicked` was erroneously not exported, and suggested renaming `into_raw_parts` to `into_parts`. (More info in my commit messages.) r? `@BurntSushi`
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jul 29, 2021
…iplett Bufwriter disassembly tweaks In rust-lang#80690 ``@BurntSushi`` observed that `WriterPanicked` was erroneously not exported, and suggested renaming `into_raw_parts` to `into_parts`. (More info in my commit messages.) r? ``@BurntSushi``
|
☀️ Test successful - checks-actions |
LeSeulArtichaut
added a commit
to LeSeulArtichaut/rust
that referenced
this pull request
Aug 25, 2021
Stabilise BufWriter::into_parts The FCP for this has already completed, in rust-lang#80690. This was just blocked on rust-lang#85901 (which changed the name), which is now merged. The original stabilisation MR was rust-lang#84770 but that has a lot of noise in it, and I also accidentally deleted the branch while trying to tidy up. So here is a new MR. Sorry for the noise. Closes rust-lang#80690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #80690 @BurntSushi observed that
WriterPanickedwas erroneously not exported, and suggested renaminginto_raw_partstointo_parts. (More info in my commit messages.)r? @BurntSushi