Rollup of 5 pull requests #86042
Closed
Rollup of 5 pull requests #86042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've already checked that `proj_base == []` in the line above and renaming `place_local` to `local` doesn't gain us anything.
otherwise evaluation could change after further substitutions.
Show test type during prints Test output can sometimes be confusing. For example doctest with the no_run argument are displayed the same way than test that are run. During rust-lang#83857 I got the feedback that test output can be confusing. For the moment test output is ``` test $DIR/test-type.rs - f (line 12) ... ignored test $DIR/test-type.rs - f (line 15) ... ok test $DIR/test-type.rs - f (line 21) ... ok test $DIR/test-type.rs - f (line 6) ... ok ``` I propose to change output by indicating the test type as ``` test $DIR/test-type.rs - f (line 12) ... ignored test $DIR/test-type.rs - f (line 15) - compile ... ok test $DIR/test-type.rs - f (line 21) - compile fail ... ok test $DIR/test-type.rs - f (line 6) ... ok ``` by indicating the test type after the test name (and in the case of doctest after the function name and line) and before the "...". ------------ Note: this is a proof of concept, the implementation is probably not optimal as the properties added in `TestDesc` are only use in the display and does not represent actual change of behavior, maybe `TestType::DocTest` could have fields
Update standard library for IntoIterator implementation of arrays This PR partially resolves issue rust-lang#84513 of updating the standard library part. I haven't found any remaining doctest examples which are using iterators over e.g. &i32 instead of just i32 in the standard library. Can anyone point me to them if there's remaining any? Thanks! r? ``@m-ou-se``
…r=jsha Rustdoc html fixes rust-lang#84480 latest update allowed me to fix the remaining issues. The last one is coming from `pulldown-cmark` so I'll send them a fix soon. r? `@jsha`
…alfJung Disallow non-monomorphic calls to `needs_drop` in interpreter otherwise evaluation could change after further substitutions.
Drop an `if let` that will always succeed We've already checked that `proj_base == []` in the line above and renaming `place_local` to `local` doesn't gain us anything. `@rustbot` modify labels +C-cleanup +T-compiler
|
@bors: r+ p=5 rollup=never |
|
📌 Commit 01bbae8 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 01bbae8 with merge 01c2eb1362084ec878a1f9870b23afdb77e6ab52... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
No error output, weird... @bors: retry |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
needs_dropin interpreter #85994 (Disallow non-monomorphic calls toneeds_dropin interpreter)if letthat will always succeed #86028 (Drop anif letthat will always succeed)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup