-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #86160
Merged
Merged
Rollup of 11 pull requests #86160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue not found during rust-lang#84988 where rustdoc is used to document cross-platform intrinsics but it was requiring that functions which use `#[target_feature]` are `unsafe` erroneously, even if they're WebAssembly specific. Rustdoc today, for example, already has a special case where it enables annotations like `#[target_feature(enable = "simd128")]` on platforms other than WebAssembly. The purpose of this commit is to relax the "require all `#[target_feature]` functions are `unsafe`" requirement for all targets whenever rustdoc is running, enabling all targets to fully document other targets, such as WebAssembly, where intrinsics functions aren't always `unsafe`.
Currently, we only point at the span of the macro argument. When the macro call is itself generated by another macro, this can make it difficult or impossible to determine which macro is responsible for producing the error.
This allows for a more readable straight-through logic in render_impl without need for a closure.
Fix documentation style inconsistencies for IP addresses Pulled out of rust-lang#85655 as it is unrelated. Fixes some inconsistencies in the docs for IP addresses: - Currently some addresses are backticked, some are not, this PR backticks everything consistently. (looks better imo) - Lowercase hex-literals are used when writing addresses.
Document `From` impls in string.rs
Add `Ipv6Addr::is_unicast` Adds an unstable utility method `Ipv6Addr::is_unicast` under the feature flag `ip` (tracking issue: rust-lang#27709). Added for completeness with the other unicast methods (see also rust-lang#85604 (comment)) and opposite of `is_multicast`.
…lts, r=oli-obk Display defaults on const params- rustdoc previously rustdoc would render this struct declaration: `pub struct Foo<const N: usize = 10>;` as: `pub struct Foo<const N: usize>;` this PR changes it to render correctly
Enable rustdoc to document safe wasm intrinsics This commit fixes an issue not found during rust-lang#84988 where rustdoc is used to document cross-platform intrinsics but it was requiring that functions which use `#[target_feature]` are `unsafe` erroneously, even if they're WebAssembly specific. Rustdoc today, for example, already has a special case where it enables annotations like `#[target_feature(enable = "simd128")]` on platforms other than WebAssembly. The purpose of this commit is to relax the "require all `#[target_feature]` functions are `unsafe`" requirement for all targets whenever rustdoc is running, enabling all targets to fully document other targets, such as WebAssembly, where intrinsics functions aren't always `unsafe`.
…k_trait_stream_position, r=dtolnay Forwarding implementation for Seek trait's stream_position method Forwarding implementations for `Seek` trait's `stream_position` were missed when it was stabilized in `1.51.0`
Include macro name in 'local ambiguity' error Currently, we only point at the span of the macro argument. When the macro call is itself generated by another macro, this can make it difficult or impossible to determine which macro is responsible for producing the error.
…umeGomez Refactor: Extract render_summary from render_impl. This allows for a more readable straight-through logic in render_impl without need for a closure. I think this will make rust-lang#85970 a bit more of a straightforward change. This is a pure refactoring. I've verified that the output of `x.py doc library/std` is byte-for-byte identical. r? `@GuillaumeGomez`
…oned-cleanup, r=petrochenkov Simplify proc_macro code using Bound::cloned().
Update books ## reference 4 commits in 9c68af3ce6ccca2395e1868addef26a0542e9ddd..8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8 2021-05-24 09:53:32 -0700 to 2021-06-01 19:00:46 +0100 - Add crate and module to glossary. (rust-lang/reference#1016) - Fix type_length_limit example. (rust-lang/reference#1026) - Rearrange HRTB grammar. (rust-lang/reference#1011) - Revert "Temporarily remove pat_param." (rust-lang/reference#1010) ## rustc-dev-guide 6 commits in 50de7f0..c8da5bf 2021-05-20 15:02:20 +0200 to 2021-06-04 09:08:56 +0200 - Fix some links (rust-lang/rustc-dev-guide#1137) - explain Miri engine vs Miri-the-tool - Add more information about no_hash query modifier. (rust-lang/rustc-dev-guide#1133) - improve section introduction - not all tools require waiting for a nightly release before they can be fixed - Describe the difference of rustc_lint vs rustc_lint_defs.
Update cargo 11 commits in 0cecbd67323ca14a7eb6505900d0d7307b00355b..aa8b09297bb3156b849e73db48af4cd050492fe6 2021-06-01 20:09:13 +0000 to 2021-06-09 00:28:53 +0000 - Add `--prune` option for cargo-tree (rust-lang/cargo#9520) - Fix typo in gitignore docs. (rust-lang/cargo#9556) - Fix typos in command_prelude.rs (rust-lang/cargo#9552) - Make clippy happy (rust-lang/cargo#9551) - Remove some dead code. (rust-lang/cargo#9546) - Add additional test for CJK progress width (rust-lang/cargo#9515) - Pull in semver 1.0.3 'x' fix (rust-lang/cargo#9544) - Add some tracking issues to unstable docs. (rust-lang/cargo#9540) - Update documentation for include/exclude. (rust-lang/cargo#9538) - Bump mdbook version for contrib guide. (rust-lang/cargo#9534) - Replace deprecated `[replace]` references with `[patch]` (rust-lang/cargo#9533)
@bors r+ p=11 rollup=never |
📌 Commit d8376f4 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jun 9, 2021
☀️ Test successful - checks-actions |
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
From
impls in string.rs #85715 (DocumentFrom
impls in string.rs)Ipv6Addr::is_unicast
#85791 (AddIpv6Addr::is_unicast
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup