Add `Ipv6Addr::is_benchmarking` #86434

CDirkx · 2021-06-18T14:18:23Z

This PR adds the unstable method Ipv6Addr::is_benchmarking. This method is added for parity with Ipv4Addr::is_benchmarking, and I intend to use it in a future rework of Ipv6Addr::is_global (edit: #86634) to more accurately follow the IANA Special Address Registry (like is done in Ipv4Addr::is_global).

With Ipv6Addr::is_benchmarking and Ipv4Addr::is_benchmarking now both existing, IpAddr::is_benchmarking is also added.

rust-highfive · 2021-06-18T14:18:26Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

CDirkx · 2021-06-18T14:19:31Z

library/std/src/net/ip/tests.rs

-            let unspecified: u16 = 1 << 0;
-            let loopback: u16 = 1 << 1;
-            let unique_local: u16 = 1 << 2;
-            let global: u16 = 1 << 3;
-            let unicast_link_local: u16 = 1 << 4;
-            let unicast_global: u16 = 1 << 7;
-            let documentation: u16 = 1 << 8;
-            let multicast_interface_local: u16 = 1 << 9;
-            let multicast_link_local: u16 = 1 << 10;
-            let multicast_realm_local: u16 = 1 << 11;
-            let multicast_admin_local: u16 = 1 << 12;
-            let multicast_site_local: u16 = 1 << 13;
-            let multicast_organization_local: u16 = 1 << 14;
-            let multicast_global: u16 = 1 << 15;
-            let multicast: u16 = multicast_interface_local
+            let unspecified: u32 = 1 << 0;
+            let loopback: u32 = 1 << 1;
+            let unique_local: u32 = 1 << 2;
+            let global: u32 = 1 << 3;
+            let unicast_link_local: u32 = 1 << 4;
+            let unicast_global: u32 = 1 << 7;
+            let documentation: u32 = 1 << 8;
+            let benchmarking: u32 = 1 << 16;
+            let multicast_interface_local: u32 = 1 << 9;
+            let multicast_link_local: u32 = 1 << 10;
+            let multicast_realm_local: u32 = 1 << 11;
+            let multicast_admin_local: u32 = 1 << 12;
+            let multicast_site_local: u32 = 1 << 13;
+            let multicast_organization_local: u32 = 1 << 14;
+            let multicast_global: u32 = 1 << 15;
+            let multicast: u32 = multicast_interface_local


More than 16 properties are now being checked, so the tag type is changed from u16 to u32. Also benchmarking is assigned value i << 16, the order doesn't really matter, only that the value is distinct from the other tags.

CDirkx · 2021-06-18T14:22:16Z

library/std/src/net/ip/tests.rs

@@ -313,6 +321,7 @@ fn ip_properties() {
    check!("ff08::", multicast);
    check!("ff0e::", global | multicast);
    check!("2001:db8:85a3::8a2e:370:7334", doc);
+    check!("2001:2::ac32:23ff:21", global | benchmarking);


According to the IANA IPv6 Special Address Registry benchmarking addresses are not globally reachable. However due to the current simplistic implementation of Ipv6Addr::is_global compared to Ipv4Addr::is_global, Rust currently considers benchmarking addresses global. I plan to address this in a future PR reworking is_global.

The rework of Ipv6Addr::is_global has been submitted (#86634).

CDirkx · 2021-06-18T14:23:19Z

library/std/src/net/ip/tests.rs

+    check!(
+        "2001:2::ac32:23ff:21",
+        &[0x20, 1, 0, 2, 0, 0, 0, 0, 0, 0, 0xac, 0x32, 0x23, 0xff, 0, 0x21],
+        global | unicast_global | benchmarking


Same as above, benchmarking addresses should not actually be globally reachable. They do however have global unicast scope.

Mark-Simulacrum · 2021-06-28T15:03:48Z

r? @joshtriplett for T-libs-api review

joshtriplett · 2021-10-04T03:17:26Z

@bors r+

bors · 2021-10-04T03:17:27Z

📌 Commit cbaccc1 has been approved by joshtriplett

…plett Add `Ipv6Addr::is_benchmarking` This PR adds the unstable method `Ipv6Addr::is_benchmarking`. This method is added for parity with `Ipv4Addr::is_benchmarking`, and I intend to use it in a future rework of `Ipv6Addr::is_global` (edit: rust-lang#86634) to more accurately follow the [IANA Special Address Registry](https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml) (like is done in `Ipv4Addr::is_global`). With `Ipv6Addr::is_benchmarking` and `Ipv4Addr::is_benchmarking` now both existing, `IpAddr::is_benchmarking` is also added.

…arth Rollup of 14 pull requests Successful merges: - rust-lang#86434 (Add `Ipv6Addr::is_benchmarking`) - rust-lang#86828 (const fn for option copied, take & replace) - rust-lang#87679 (BTree: refine some comments) - rust-lang#87910 (Mark unsafe methods NonZero*::unchecked_(add|mul) as const.) - rust-lang#88286 (Remove unnecessary unsafe block in `process_unix`) - rust-lang#88305 (Manual Debug for Unix ExitCode ExitStatus ExitStatusError) - rust-lang#88353 (Partially stabilize `array_methods`) - rust-lang#88370 (Add missing `# Panics` section to `Vec` method) - rust-lang#88481 (Remove some feature gates) - rust-lang#89138 (Fix link in Ipv6Addr::to_ipv4 docs) - rust-lang#89401 (Add truncate note to Vec::resize) - rust-lang#89467 (Fix typos in rustdoc/lints) - rust-lang#89472 (Only register `WSACleanup` if `WSAStartup` is actually ever called) - rust-lang#89505 (Add regression test for spurious const error with NLL) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

CDirkx added 2 commits June 18, 2021 15:56

Add Ipv6Addr::is_benchmarking

e2d6334

Add IpAddr::is_benchmarking

cbaccc1

rustbot added A-io Area: std::io, std::fs, std::net and std::path T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2021

rust-highfive assigned Mark-Simulacrum Jun 18, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2021

CDirkx commented Jun 18, 2021

View reviewed changes

CDirkx mentioned this pull request Jun 20, 2021

Add Ipv6Addr::is_ipv4_mapped #86490

Closed

This comment has been minimized.

Sign in to view

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 23, 2021

rust-highfive assigned joshtriplett and unassigned Mark-Simulacrum Jun 28, 2021

CDirkx mentioned this pull request Jul 7, 2021

Stabilize the "IP" feature (continued from #76098) #85585

Closed

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2021

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2021

This comment has been minimized.

Sign in to view

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2021

joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2021

JohnCSimon removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2021

JohnCSimon added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2021

This was referenced Oct 4, 2021

Rollup of 14 pull requests #89510

Closed

Rollup of 14 pull requests #89512

Merged

bors merged commit 22714ed into rust-lang:master Oct 4, 2021

rustbot added this to the 1.57.0 milestone Oct 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Ipv6Addr::is_benchmarking` #86434

Add `Ipv6Addr::is_benchmarking` #86434

CDirkx commented Jun 18, 2021 •

edited

Loading

rust-highfive commented Jun 18, 2021

CDirkx Jun 18, 2021 •

edited

Loading

CDirkx Jun 18, 2021 •

edited

Loading

CDirkx Jun 25, 2021

CDirkx Jun 18, 2021

This comment has been minimized.

Mark-Simulacrum commented Jun 28, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshtriplett commented Oct 4, 2021

bors commented Oct 4, 2021

Add Ipv6Addr::is_benchmarking #86434

Add Ipv6Addr::is_benchmarking #86434

Conversation

CDirkx commented Jun 18, 2021 • edited Loading

rust-highfive commented Jun 18, 2021

CDirkx Jun 18, 2021 • edited Loading

Choose a reason for hiding this comment

CDirkx Jun 18, 2021 • edited Loading

Choose a reason for hiding this comment

CDirkx Jun 25, 2021

Choose a reason for hiding this comment

CDirkx Jun 18, 2021

Choose a reason for hiding this comment

This comment has been minimized.

Mark-Simulacrum commented Jun 28, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

joshtriplett commented Oct 4, 2021

bors commented Oct 4, 2021

Add `Ipv6Addr::is_benchmarking` #86434

Add `Ipv6Addr::is_benchmarking` #86434

CDirkx commented Jun 18, 2021 •

edited

Loading

CDirkx Jun 18, 2021 •

edited

Loading

CDirkx Jun 18, 2021 •

edited

Loading