Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unsized suggestions #86454

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Refactor unsized suggestions #86454

merged 5 commits into from
Sep 3, 2021

Conversation

tlyu
Copy link
Contributor

@tlyu tlyu commented Jun 19, 2021

@rustbot label +A-diagnostics +A-traits +A-typesystem +C-cleanup +T-compiler

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints A-traits Area: Trait system A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 19, 2021
@rust-highfive
Copy link
Collaborator

r? @LeSeulArtichaut

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 19, 2021
@tlyu tlyu mentioned this pull request Jun 19, 2021
Merged
@LeSeulArtichaut
Copy link
Contributor

I'm not the right reviewer for this. Maybe r? @estebank

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2021
@camelid
Copy link
Member

camelid commented Sep 2, 2021

triage: r? @davidtwco (feel free to reassign)

@rust-highfive rust-highfive assigned davidtwco and unassigned estebank Sep 2, 2021
davidtwco
davidtwco approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 3, 2021

📌 Commit 3252432 has been approved by davidtwco

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2021
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 3, 2021
@bors
Copy link
Contributor

bors commented Sep 3, 2021

⌛ Testing commit 3252432 with merge e4e4179...

@bors
Copy link
Contributor

bors commented Sep 3, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing e4e4179 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2021
@bors bors merged commit e4e4179 into rust-lang:master Sep 3, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 3, 2021
@tlyu tlyu deleted the refactor-unsized-suggestions branch November 16, 2021 04:51
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 16, 2021
@JohnTitor
Rollup merge of rust-lang#86455 - tlyu:check-where-before-suggesting-…
37cf942 
…unsized, r=estebank

check where-clause for explicit `Sized` before suggesting `?Sized`

Fixes rust-lang#85945.

Based on rust-lang#86454.

`@rustbot` label +A-diagnostics +A-traits +A-typesystem +D-papercut +T-compiler
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 16, 2021
@JohnTitor
Rollup merge of rust-lang#86455 - tlyu:check-where-before-suggesting-…
ebef3ce 
…unsized, r=estebank

check where-clause for explicit `Sized` before suggesting `?Sized`

Fixes rust-lang#85945.

Based on rust-lang#86454.

``@rustbot`` label +A-diagnostics +A-traits +A-typesystem +D-papercut +T-compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-traits Area: Trait system A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
9 participants
@tlyu @rust-highfive @LeSeulArtichaut @camelid @davidtwco @bors @estebank @JohnCSimon @rustbot