Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorKind::DirNotEmpty #86553

Closed
wants to merge 1 commit into from
Closed

Add ErrorKind::DirNotEmpty #86553

wants to merge 1 commit into from

Conversation

rouge8
Copy link

@rouge8 rouge8 commented Jun 22, 2021

This patch adds the ability to express ENOTEMPTY as an io::Error.

I followed #84744 to see what needed to be updated.

This patch adds the ability to express `ENOTEMPTY` as an `io::Error`.
@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2021
@the8472
Copy link
Member

the8472 commented Jun 22, 2021

If approved #79965 would make this redundant.

@rouge8
Copy link
Author

rouge8 commented Jun 22, 2021

If approved #79965 would make this redundant.

Ah that looks like a more comprehensive approach!

@rouge8 rouge8 closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants